Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handing out merge rights on first PR merge #10

Closed
betatim opened this issue Mar 17, 2017 · 2 comments
Closed

Handing out merge rights on first PR merge #10

betatim opened this issue Mar 17, 2017 · 2 comments

Comments

@betatim
Copy link
Member

betatim commented Mar 17, 2017

There are various ways of working together and organising open-source projects. The one I believe in most is the "someone else has to merge your PR" rule. (assuming the basics like automatic tests etc are covered)

This creates a bit of a challenge for new projects, because often there is only one or two people ... a popular way around it is to offer to bestow the privilege of merging PRs on anyone who has a PR merged. I can imagine all sorts of ways that this could go wrong or lead to stress etc but in my (limited) experience it works well in practice.

If there is no objection voiced here I will start following this for all future PRs. I wouldn't broadly advertise it, just ask people when their first PR is merged.

@ctb
Copy link
Member

ctb commented Mar 17, 2017

You should link to the Pull Request Hack!

I'm on board.

@benlindsay
Copy link
Collaborator

@betatim or @ctb Can we close this? (I'm just seeing if we can clean up old issues)

@betatim betatim closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants