Refactoring to improve cohesion #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JerseyApplication contains a lot of lifecycle code that could be eliminated if the application is made immutable. This commit delays the creation of the JerseyApplication until first access, but then marks the provider as locked. This fits with the new usage pattern where providers are cloned rather than modified. Signed-off-by: Tim Ward <timothyjward@apache.org>
The JerseyApplication dynamic subclassing should live alongside our other ASM usage in the proxy package. Signed-off-by: Tim Ward <timothyjward@apache.org>
The JerseyServiceRuntime was responsible for adding the feature which tracked the lifecycle of the container. This is better located in the JerseyApplication which is already responsible for registering custom callbacks. Signed-off-by: Tim Ward <timothyjward@apache.org>
The WhiteboardServletContainer was responsible for adding the components which supplied Promise handling and SSE handling to the container. This is better located in the JerseyApplication so that all containers gain the benefit. Signed-off-by: Tim Ward <timothyjward@apache.org>
maho7791
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several portions of the codebase that share responsibility for registering the custom types that we need for the whiteboard to work correctly. This series of commits centralises these registrations in the JerseyApplication, simplifying the JerseyServiceRuntime and the WhiteboardServletContainer. The commit also makes the JerseyApplication immutable once created, dramatically simplifying the lifecycle of the objects.