Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log marker and stacktrace on Darwin #379

Merged
merged 2 commits into from Jan 15, 2024
Merged

Log marker and stacktrace on Darwin #379

merged 2 commits into from Jan 15, 2024

Conversation

Gaming32
Copy link
Contributor

@Gaming32 Gaming32 commented Dec 5, 2023

Resolves #375

@oshai
Copy link
Owner

oshai commented Dec 6, 2023

There are some failures in CI, also if you can add a test that would be great.

@Gaming32
Copy link
Contributor Author

Gaming32 commented Dec 7, 2023

I fixed Spotless, but I don't really know how I can add a test for this.

@oshai
Copy link
Owner

oshai commented Dec 8, 2023

I don't really know how I can add a test for this.

One way will be to extract the logic to a class / object DarwinFormatter and unit test the returned string in some scenarios.

@oshai oshai merged commit d13df90 into oshai:master Jan 15, 2024
5 checks passed
StefanLobbenmeier pushed a commit to StefanLobbenmeier/yt-dlp-compose that referenced this pull request Jan 21, 2024
@renovate
REN - Update dependency io.github.oshai:kotlin-logging-jvm to v6 (#13)
e67fa81 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging)
| `5.1.1` -> `6.0.3` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/io.github.oshai:kotlin-logging-jvm/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.github.oshai:kotlin-logging-jvm/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.github.oshai:kotlin-logging-jvm/5.1.1/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.github.oshai:kotlin-logging-jvm/5.1.1/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>oshai/kotlin-logging
(io.github.oshai:kotlin-logging-jvm)</summary>

###
[`v6.0.3`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.3)

[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.2...6.0.3)

#### What's Changed

- Add Kotlin/Wasm (JS browser) support by
[@&#8203;AzimMuradov](https://togithub.com/AzimMuradov) in
[oshai/kotlin-logging#388
- Bump com.diffplug.spotless from 6.23.3 to 6.24.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#390
- Bump actions/upload-pages-artifact from 2 to 3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#391
- Bump actions/deploy-pages from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#392
- Bump actions/cache from 3.3.2 to 3.3.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#393
- Log marker and stacktrace on Darwin by
[@&#8203;Gaming32](https://togithub.com/Gaming32) in
[oshai/kotlin-logging#379

#### New Contributors

- [@&#8203;Gaming32](https://togithub.com/Gaming32) made their first
contribution in
[oshai/kotlin-logging#379

**Full Changelog**:
oshai/kotlin-logging@6.0.2...6.0.3

###
[`v6.0.2`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.2)

[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.1...6.0.2)

#### What's Changed

- Bump multiplatform from 1.9.21 to 1.9.22 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#385
- Remove detekt by
[@&#8203;AzimMuradov](https://togithub.com/AzimMuradov) in
[oshai/kotlin-logging#387
- Add workflow to publish Dokka HTML docs to project site by
[@&#8203;EdricChan03](https://togithub.com/EdricChan03) in
[oshai/kotlin-logging#383

#### New Contributors

- [@&#8203;EdricChan03](https://togithub.com/EdricChan03) made their
first contribution in
[oshai/kotlin-logging#383

**Full Changelog**:
oshai/kotlin-logging@6.0.1...6.0.2

###
[`v6.0.1`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.1)

[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.0...6.0.1)

#### What's Changed

- Bump com.diffplug.spotless from 6.22.0 to 6.23.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#377
- Bump actions/setup-java from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#376
- Bump org.jetbrains.dokka from 1.8.20 to 1.9.10 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#366

**Full Changelog**:
oshai/kotlin-logging@6.0.0...6.0.1

###
[`v6.0.0`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.0)

[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/5.1.4...6.0.0)

#### What's Changed

- Update Kotlin to 1.9.21 by
[@&#8203;AzimMuradov](https://togithub.com/AzimMuradov) in
[oshai/kotlin-logging#380

#### New Contributors

- [@&#8203;AzimMuradov](https://togithub.com/AzimMuradov) made their
first contribution in
[oshai/kotlin-logging#380

**Full Changelog**:
oshai/kotlin-logging@5.1.2...6.0.0

###
[`v5.1.4`](https://togithub.com/oshai/kotlin-logging/releases/tag/5.1.4)

[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/5.1.1...5.1.4)

#### What's Changed

- fix - protect from uncontrolled format string by
[@&#8203;oshai](https://togithub.com/oshai) in
[oshai/kotlin-logging#381

**Full Changelog**:
oshai/kotlin-logging@5.1.1...5.1.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/StefanLobbenmeier/yt-dlp-compose).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuMTM1LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
nikclayton pushed a commit to pachli/pachli-android that referenced this pull request Mar 4, 2024
@renovate
fix(deps): update dependency io.github.oshai:kotlin-logging-jvm to v6…
e5d0147 
….0.3 (#362)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging)
| `5.1.4` -> `6.0.3` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/io.github.oshai:kotlin-logging-jvm/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.github.oshai:kotlin-logging-jvm/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.github.oshai:kotlin-logging-jvm/5.1.4/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.github.oshai:kotlin-logging-jvm/5.1.4/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging)
| `6.0.1` -> `6.0.3` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/io.github.oshai:kotlin-logging-jvm/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.github.oshai:kotlin-logging-jvm/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.github.oshai:kotlin-logging-jvm/6.0.1/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.github.oshai:kotlin-logging-jvm/6.0.1/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>oshai/kotlin-logging
(io.github.oshai:kotlin-logging-jvm)</summary>

###
[`v6.0.3`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.3)

[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.2...6.0.3)

#### What's Changed

- Add Kotlin/Wasm (JS browser) support by
[@&#8203;AzimMuradov](https://togithub.com/AzimMuradov) in
[oshai/kotlin-logging#388
- Bump com.diffplug.spotless from 6.23.3 to 6.24.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#390
- Bump actions/upload-pages-artifact from 2 to 3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#391
- Bump actions/deploy-pages from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#392
- Bump actions/cache from 3.3.2 to 3.3.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#393
- Log marker and stacktrace on Darwin by
[@&#8203;Gaming32](https://togithub.com/Gaming32) in
[oshai/kotlin-logging#379

#### New Contributors

- [@&#8203;Gaming32](https://togithub.com/Gaming32) made their first
contribution in
[oshai/kotlin-logging#379

**Full Changelog**:
oshai/kotlin-logging@6.0.2...6.0.3

###
[`v6.0.2`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.2)

[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.1...6.0.2)

#### What's Changed

- Bump multiplatform from 1.9.21 to 1.9.22 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#385
- Remove detekt by
[@&#8203;AzimMuradov](https://togithub.com/AzimMuradov) in
[oshai/kotlin-logging#387
- Add workflow to publish Dokka HTML docs to project site by
[@&#8203;EdricChan03](https://togithub.com/EdricChan03) in
[oshai/kotlin-logging#383

#### New Contributors

- [@&#8203;EdricChan03](https://togithub.com/EdricChan03) made their
first contribution in
[oshai/kotlin-logging#383

**Full Changelog**:
oshai/kotlin-logging@6.0.1...6.0.2

###
[`v6.0.1`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.1)

[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.0...6.0.1)

#### What's Changed

- Bump com.diffplug.spotless from 6.22.0 to 6.23.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#377
- Bump actions/setup-java from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#376
- Bump org.jetbrains.dokka from 1.8.20 to 1.9.10 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[oshai/kotlin-logging#366

**Full Changelog**:
oshai/kotlin-logging@6.0.0...6.0.1

###
[`v6.0.0`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.0)

[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/5.1.4...6.0.0)

#### What's Changed

- Update Kotlin to 1.9.21 by
[@&#8203;AzimMuradov](https://togithub.com/AzimMuradov) in
[oshai/kotlin-logging#380

#### New Contributors

- [@&#8203;AzimMuradov](https://togithub.com/AzimMuradov) made their
first contribution in
[oshai/kotlin-logging#380

**Full Changelog**:
oshai/kotlin-logging@5.1.2...6.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/pachli/pachli-android).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Darwin doesn't log stacktraces
2 participants
@Gaming32 @oshai