New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added additional pseudo filesystems #1105
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1105 +/- ##
=========================================
Coverage 74.66% 74.66%
Complexity 2 2
=========================================
Files 27 27
Lines 1342 1342
Branches 170 170
=========================================
Hits 1002 1002
Misses 263 263
Partials 77 77 Continue to review full report at Codecov.
|
@@ -58,32 +58,47 @@ | |||
|
|||
// Linux defines a set of virtual file systems | |||
private static final List<String> PSEUDO_FS = Arrays.asList(// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please move this to the AbstractFileSystem object (and make it protected
)? The SolarisFileSystem and FreeBSDFileSystem need something similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, and you want those from Solaris and FreeBSD added into the same list?
Looks great! Merging! Fixes #1104 |
Hi, any plans to do a release in the near future? |
I was planning on one later this week after completing some WMI Refactoring (#1108) but can push one out earlier if needed. |
An early release would be great ... need to push the fix regarding the local mounts to systems soon. And I would prefer to use a real release so I can just include OSHI via maven ... |
It is possible to directly link to snapshot releases via Maven, but I get it. Pushing out 4.4.1 now, expect it on Maven within a few hours. |
Thanks a lot ... already building :) |
No description provided.