Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional pseudo filesystems #1105

Merged
merged 5 commits into from Feb 13, 2020
Merged

Added additional pseudo filesystems #1105

merged 5 commits into from Feb 13, 2020

Conversation

Space2Man
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Feb 13, 2020

Coverage Status

Coverage remained the same at 78.838% when pulling 6cadb69 on Space2Man:master into 5cadbd0 on oshi:master.

@codecov-io
Copy link

codecov-io commented Feb 13, 2020

Codecov Report

Merging #1105 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1105   +/-   ##
=========================================
  Coverage     74.66%   74.66%           
  Complexity        2        2           
=========================================
  Files            27       27           
  Lines          1342     1342           
  Branches        170      170           
=========================================
  Hits           1002     1002           
  Misses          263      263           
  Partials         77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d360b1b...6cadb69. Read the comment docs.

@@ -58,32 +58,47 @@

// Linux defines a set of virtual file systems
private static final List<String> PSEUDO_FS = Arrays.asList(//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move this to the AbstractFileSystem object (and make it protected)? The SolarisFileSystem and FreeBSDFileSystem need something similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, and you want those from Solaris and FreeBSD added into the same list?

@dbwiddis
Copy link
Member

Looks great! Merging! Fixes #1104

@dbwiddis dbwiddis merged commit 0cee9ab into oshi:master Feb 13, 2020
@Space2Man
Copy link
Contributor Author

Hi, any plans to do a release in the near future?

@dbwiddis
Copy link
Member

I was planning on one later this week after completing some WMI Refactoring (#1108) but can push one out earlier if needed.

@Space2Man
Copy link
Contributor Author

An early release would be great ... need to push the fix regarding the local mounts to systems soon. And I would prefer to use a real release so I can just include OSHI via maven ...

@dbwiddis
Copy link
Member

It is possible to directly link to snapshot releases via Maven, but I get it. Pushing out 4.4.1 now, expect it on Maven within a few hours.

@Space2Man
Copy link
Contributor Author

Thanks a lot ... already building :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants