Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor WMI boilerplate to own classes #1108

Merged
merged 28 commits into from
Feb 21, 2020
Merged

Refactor WMI boilerplate to own classes #1108

merged 28 commits into from
Feb 21, 2020

Conversation

dbwiddis
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Feb 16, 2020

Coverage Status

Coverage decreased (-12.9%) to 65.904% when pulling be3eb26 on dbwiddis:wmi-refactor into e69cc36 on oshi:master.

@codecov-io
Copy link

codecov-io commented Feb 16, 2020

Codecov Report

Merging #1108 into master will increase coverage by 2.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1108      +/-   ##
============================================
+ Coverage     60.41%   62.45%   +2.03%     
  Complexity        2        2              
============================================
  Files            55       56       +1     
  Lines          1675     1662      -13     
  Branches        177      178       +1     
============================================
+ Hits           1012     1038      +26     
+ Misses          586      547      -39     
  Partials         77       77
Impacted Files Coverage Δ Complexity Δ
...i-core/src/main/java/oshi/util/tuples/Quartet.java 100% <ø> (+100%) 0 <0> (ø) ⬇️
oshi-core/src/main/java/oshi/util/tuples/Pair.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...i-core/src/main/java/oshi/util/tuples/Quintet.java 100% <ø> (+100%) 0 <0> (ø) ⬇️
...i-core/src/main/java/oshi/util/tuples/Triplet.java 100% <100%> (ø) 0 <0> (?)
...i-demo/src/main/java/oshi/demo/OshiHTTPServer.java 0% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94042be...be3eb26. Read the comment docs.

@dbwiddis
Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- oshi-core/src/main/java/oshi/driver/wmi/OhmHardware.java  1
- oshi-core/src/main/java/oshi/util/tuples/Quartet.java  1
- oshi-core/src/main/java/oshi/driver/perfmon/PagingFile.java  1
- oshi-core/src/main/java/oshi/util/tuples/Pair.java  1
- oshi-core/src/main/java/oshi/driver/wmi/Win32Bios.java  1
- oshi-core/src/main/java/oshi/driver/wmi/Win32PhysicalMemory.java  1
- oshi-core/src/main/java/oshi/driver/wmi/Win32Processor.java  1
- oshi-core/src/main/java/oshi/driver/wmi/Win32BaseBoard.java  1
- oshi-core/src/main/java/oshi/hardware/platform/windows/WindowsFirmware.java  1
- oshi-core/src/main/java/oshi/driver/perfmon/PhysicalDisk.java  1
- oshi-core/src/main/java/oshi/util/tuples/Quintet.java  1
- oshi-core/src/main/java/oshi/driver/wmi/Win32PnPEntity.java  1
- oshi-core/src/main/java/oshi/driver/wmi/Win32Process.java  4
- oshi-core/src/main/java/oshi/driver/wmi/Win32DiskDriveToDiskPartition.java  1
- oshi-core/src/main/java/oshi/driver/perfmon/ProcessorInformation.java  3
- oshi-core/src/main/java/oshi/driver/perfmon/SystemInformation.java  1
- oshi-core/src/main/java/oshi/driver/wmi/Win32LogicalDisk.java  5
- oshi-core/src/main/java/oshi/driver/wmi/Win32ComputerSystem.java  1
- oshi-core/src/main/java/oshi/driver/wmi/Win32USBController.java  1
- oshi-core/src/main/java/oshi/driver/perfmon/ProcessInformation.java  1
- oshi-core/src/main/java/oshi/driver/perfmon/ThermalZoneInformation.java  1
- oshi-core/src/main/java/oshi/driver/wmi/Win32ComputerSystemProduct.java  1
- oshi-core/src/main/java/oshi/driver/wmi/Win32LogicalDiskToPartition.java  1
- oshi-core/src/test/java/oshi/util/TupleTest.java  1
- oshi-core/src/main/java/oshi/hardware/platform/windows/WindowsComputerSystem.java  1
- oshi-core/src/main/java/oshi/driver/wmi/OhmSensor.java  1
- oshi-core/src/main/java/oshi/driver/perfmon/MemoryInformation.java  1
- oshi-core/src/main/java/oshi/driver/wmi/Win32OperatingSystem.java  1
- oshi-core/src/main/java/oshi/driver/wmi/Win32DiskPartition.java  1
- oshi-core/src/main/java/oshi/hardware/platform/windows/WindowsBaseboard.java  1
- oshi-core/src/main/java/oshi/driver/wmi/Win32DiskDrive.java  1
- oshi-core/src/main/java/oshi/driver/wmi/Win32Fan.java  1
         

Complexity decreasing per file
==============================
+ oshi-core/src/main/java/oshi/software/os/windows/WindowsOperatingSystem.java  -5
         

See the complete overview on Codacy

@dbwiddis dbwiddis merged commit f488aa9 into oshi:master Feb 21, 2020
@dbwiddis dbwiddis deleted the wmi-refactor branch February 21, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants