-
-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get services #981
Get services #981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the compilation errors and tested on Windows. Comments inline. Will test on macOS tonight. What VMs do you have for testing?
oshi-core/src/main/java/oshi/software/common/AbstractOperatingSystem.java
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/software/os/linux/LinuxOperatingSystem.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/software/os/linux/LinuxOperatingSystem.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/software/os/linux/LinuxOperatingSystem.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/software/os/mac/MacOperatingSystem.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/software/os/windows/WindowsOperatingSystem.java
Outdated
Show resolved
Hide resolved
I have a Linux VM. Will have changes committed by tomorrow night. |
Codecov Report
@@ Coverage Diff @@
## master #981 +/- ##
===========================================
+ Coverage 77.17% 77.38% +0.2%
Complexity 2 2
===========================================
Files 23 24 +1
Lines 1196 1207 +11
Branches 154 155 +1
===========================================
+ Hits 923 934 +11
Misses 206 206
Partials 67 67
Continue to review full report at Codecov.
|
oshi-core/src/main/java/oshi/software/os/linux/LinuxOperatingSystem.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/software/os/mac/MacOperatingSystem.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/software/os/mac/MacOperatingSystem.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/software/os/mac/MacOperatingSystem.java
Outdated
Show resolved
Hide resolved
d4169ae
to
a8995bb
Compare
a8995bb
to
6e7acb3
Compare
aacd799
to
19f5c5f
Compare
e1d9c02
to
56cccc7
Compare
This pull request introduces 3 alerts when merging 66bfb70 into ff6fa94 - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging e2f01ee into ff6fa94 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging c99b36c into ff6fa94 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging bffb1b3 into ff6fa94 - view on LGTM.com new alerts:
|
Get Services Implementation. Fixes #257