Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get services #981

Merged
merged 51 commits into from
Oct 12, 2019
Merged

Get services #981

merged 51 commits into from
Oct 12, 2019

Conversation

agithyogendra
Copy link
Contributor

@agithyogendra agithyogendra commented Sep 3, 2019

Get Services Implementation. Fixes #257

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the compilation errors and tested on Windows. Comments inline. Will test on macOS tonight. What VMs do you have for testing?

@agithyogendra
Copy link
Contributor Author

agithyogendra commented Sep 4, 2019

I have a Linux VM. Will have changes committed by tomorrow night.

@coveralls
Copy link

coveralls commented Sep 5, 2019

Coverage Status

Coverage increased (+0.2%) to 81.193% when pulling 1905443 on agithyogendra:Get-Services into ff6fa94 on oshi:master.

@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #981 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #981     +/-   ##
===========================================
+ Coverage     77.17%   77.38%   +0.2%     
  Complexity        2        2             
===========================================
  Files            23       24      +1     
  Lines          1196     1207     +11     
  Branches        154      155      +1     
===========================================
+ Hits            923      934     +11     
  Misses          206      206             
  Partials         67       67
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/oshi/software/os/OperatingSystem.java 76.47% <ø> (ø) 0 <0> (ø) ⬇️
oshi-core/src/main/java/oshi/util/ParseUtil.java 94.88% <100%> (+0.02%) 0 <0> (ø) ⬇️
...core/src/main/java/oshi/software/os/OSService.java 100% <100%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff6fa94...1905443. Read the comment docs.

@oshi oshi deleted a comment Sep 9, 2019
@oshi oshi deleted a comment Oct 11, 2019
@lgtm-com
Copy link

lgtm-com bot commented Oct 12, 2019

This pull request introduces 3 alerts when merging 66bfb70 into ff6fa94 - view on LGTM.com

new alerts:

  • 3 for Useless comparison test

@lgtm-com
Copy link

lgtm-com bot commented Oct 12, 2019

This pull request introduces 3 alerts when merging e2f01ee into ff6fa94 - view on LGTM.com

new alerts:

  • 3 for Useless comparison test

@lgtm-com
Copy link

lgtm-com bot commented Oct 12, 2019

This pull request introduces 2 alerts when merging c99b36c into ff6fa94 - view on LGTM.com

new alerts:

  • 2 for Useless comparison test

@lgtm-com
Copy link

lgtm-com bot commented Oct 12, 2019

This pull request introduces 2 alerts when merging bffb1b3 into ff6fa94 - view on LGTM.com

new alerts:

  • 2 for Useless comparison test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get all services running on system
4 participants