circle ciでコードの静的解析を行うようにした #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madogiwa0124
force-pushed
the
add_lint
branch
2 times, most recently
from
892ceca
to
56d2e92
Compare
madogiwa0124
force-pushed
the
add_lint
branch
from
ef1cdb2
to
a7b1e94
Compare
madogiwa0124
force-pushed
the
add_lint
branch
from
aeab49b
to
894827b
Compare
madogiwa0124
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
とりあえずCIでLintが走るようにして、
tslint --fixで自動で直せるところは直してます 👮一応、既存ですぐ直せそうなとこは直しましたが、その他については一旦静的解析を適用しないようにしています。(空いた時間で少しずつ、適用するルールを増やしていければと。。。)
https://github.com/oshidori-app/oshidori/blob/d1aac1a9c1a3722096556bf43ceb9e158aa09429/tslint.json
このPRのマージ後は静的解析が落ちたらCIも落ちるようになるので、ご注意くださいm(_ _)m