Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify membership objects instead of replacing them in the MembershipList #36

Open
osks opened this issue Feb 10, 2013 · 0 comments
Open
Labels

Comments

@osks
Copy link
Owner

osks commented Feb 10, 2013

To reduce code complexity in controllers, we should not replace the membership objects or the unread_texts arrays, but rather keep the same objects and modify them when we need to update something. For example in the ReadConferenceTextsCtrl we have to $watch the membership to see if it changes so we always have the newest list of unread texts.

It will make the MembershipList code a bit more complex/hard, but it's just one place compared to multiple controllers (more so in the future).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant