Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add baseurl variable to config & use it before getting routes #90

Closed
wants to merge 1 commit into from
Closed

Conversation

oskar-gmerek
Copy link

This is simply temporary solution for working with custom baseUrl. (#88 #89)

For now users can define baseUrl in vantage config.

But in the future that should be automagically checked from tsconfig.json and next.config.js

Example:
"baseUrl": "./src"

I don't know if it's possible to contribute for docs.

@mnoah1
Copy link
Contributor

mnoah1 commented Apr 7, 2022

Thank you for the submission. I just approved #91 which just uses a true/false to specify whether to check for pages in src or the project root. It seems that a true/false should work here as Next only officially supports putting pages either in the root or in /src. Do you feel there is a use case where the use should be able to specify something other than src?

@oskar-gmerek
Copy link
Author

oskar-gmerek commented Apr 7, 2022

@mnoah1 Not sure about other cases, I just think it is more semantic to define it as string if it is string in tsconfig. Anyway I strongly feel that variable should be reading value from tsconfig and next.config as long as you targeting wider with that project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants