Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edited comments and fixed SessionManager #6

Merged
merged 4 commits into from
Feb 9, 2021
Merged

Edited comments and fixed SessionManager #6

merged 4 commits into from
Feb 9, 2021

Conversation

alcheng005
Copy link
Contributor

No description provided.

@ed-deng
Copy link
Contributor

ed-deng commented Feb 9, 2021

looks good fam

BAlexanderNance
BAlexanderNance approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@BAlexanderNance BAlexanderNance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a little light for a PL. try to get a bit more before done.

@BAlexanderNance BAlexanderNance merged commit ebdf3e1 into oslabs-beta:main Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BAlexanderNance BAlexanderNance BAlexanderNance approved these changes

@ed-deng ed-deng ed-deng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alcheng005 @ed-deng @BAlexanderNance