Vector class doesn't store the std attribute

[vetlewi]

When I save a Vector object to file I would expect that all the attributes would be saved such that all attributes would be the same after loading back from file.

[fzeiser]

Hei! That's indeed a bug. It can be changed for saving in numpy format and plain text, but not directly for mama. Therefore I propose to check if std is set. If if not, proceed as before. If it is, create an additional file with [...]_std; and the corresponding thing with the load function; it might be nice to set a debug message to the logger.

For numpy/plain text one could also just save the additional column; that would be easier.

[vetlewi]

I see that this is also missing for the Matrix class.

I'm currently trying to implement a fix.
How about giving the user a warning if trying to save in MaMa format while the std is set?

[vetlewi]

For numpy/plain text one could also just save the additional column; that would be easier.

This will break backwards compatibility, is that OK?

[fzeiser]

I don't see how it breaks the compatibility; it's just that the attributes will not be loaded with any version before the bugfix, isn't it?

ompy/ompy/filehandling.py

Lines 280 to 310 in be782f2

	def load_txt_2D(path: Union[str, Path]
	) -> Tuple[np.ndarray, np.ndarray, np.ndarray]:
	mat = np.loadtxt(path)
	return mat[1:, 1:], mat[0, 1:], mat[1:, 0]
	def load_numpy_1D(path: Union[str, Path]) -> Tuple[np.ndarray, np.ndarray]:
	vec = np.load(path)
	E = vec[:, 0]
	values = vec[:, 1]
	return values, E
	def save_numpy_1D(values: np.ndarray, E: np.ndarray,
	path: Union[str, Path]) -> None:
	mat = np.column_stack((E, values))
	np.save(path, mat)
	def load_txt_1D(path: Union[str, Path]) -> Tuple[np.ndarray, np.ndarray]:
	vec = np.loadtxt(path)
	E = vec[:, 0]
	values = vec[:, 1]
	return values, E
	def save_txt_1D(values: np.ndarray, E: np.ndarray,
	path: Union[str, Path], header='E[keV] values') -> None:
	""" E default in keV """
	mat = np.column_stack([E, values])
	np.savetxt(path, mat, header=header)

[fzeiser]

How about giving the user a warning if trying to save in MaMa format while the std is set?

ok