Fix of bug #140 #141
Merged
Fix of bug #140 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a short section to |
fzeiser
reviewed
Jul 29, 2020
fzeiser
reviewed
Jul 29, 2020
fzeiser
reviewed
Jul 29, 2020
fzeiser
requested changes
Jul 29, 2020
|
Note: You don't have to fix (all) codeclimate issues. Howver, the docs should work, so this is actually a problem: |
fzeiser
reviewed
Jul 29, 2020
fzeiser
requested changes
Jul 29, 2020
|
Very good job, thanks! |
fzeiser
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should close issue #140 the bug of missing vector attribute when saving/loading from disk.
I've made a new issue for the same bug in the matrix class (see issue #142).