Add analyser for eclExt data format in France #1862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please can you rename files:
|
frodrigo
reviewed
May 14, 2023
Comment on lines
31
to
35
| self.def_class_missing_official(item = 8090, id = 11, level = 3, tags = ['merge', 'eclairage', 'eclext', 'fix:chair', 'fix:survey'], | ||
| title = T_('Street light not integrated')) | ||
| self.def_class_possible_merge(item = 8091, id = 13, level = 3, tags = ['merge', 'eclairage', 'eclext', 'fix:chair', 'fix:picture'], | ||
| title = T_('Street light integration suggestion')) | ||
| self.def_class_update_official(item = 8092, id = 14, level = 3, tags = ['merge', 'eclairage', 'eclext', 'fix:chair', 'fix:survey'], |
There was a problem hiding this comment.
Ids should go to Analyser_Merge_Eclext_FR_Syane
There was a problem hiding this comment.
Is it necessary?
I was inspired by analyser_merge_hydrants_FR.py
There was a problem hiding this comment.
You split into two file to make reusable. So yes.
I was inspired by analyser_merge_hydrants_FR.py
That bad. But in this case it works anyway.
There was a problem hiding this comment.
Should we create an issue for that?
frodrigo
reviewed
May 14, 2023
frodrigo
reviewed
May 14, 2023
frodrigo
reviewed
May 14, 2023
frodrigo
reviewed
May 14, 2023
frodrigo
reviewed
May 14, 2023
|
You also nee to add your new analyser to the configuration. |
|
@frodrigo could you give me proper ids and classes for that please? |
frodrigo
pushed a commit
to frodrigo/osmose-backend
that referenced
this pull request
May 18, 2023
|
Thank you. Fixed and merged manually. |
frodrigo
pushed a commit
that referenced
this pull request
May 18, 2023
|
@flacombe it is deployed, but it fails with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EclExt is a French national standard for street lighting data
http://cnig.gouv.fr/eclairage-exterieur-a25020.html
Starting with a file over Haute-Savoie published by Syane.