-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geos36 #636
Geos36 #636
Conversation
Wouldn't it be simpler to just use Does this still compile with GEOS 3.5 and smaller? |
Travis will check with 3.3.8, my main concerns are memory leaks in either version, thread safety, and performances. |
getDefaultInstance is not thread-safe. You'll have to create a new factory locally if you need that. |
getDefaultInstance definition is here: At this stage the Factory has no state, so shouldn't be a big deal to use from multiple threads (beside taking care of not leaking one by calling getDefaultInstance at the same time by multiple threads). But in the future things may change. The C-API of GEOS has a thread-safe interface, and you should still switch to it for API stability. |
any update here? |
ping @darkblue-b |
Fixed by #684 |
this built and tests passed, with the following Ubuntu 1404 Trusty config :