Add Arnis #140
Merged
Add Arnis #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnalis
approved these changes
Jun 12, 2023
Unkn0wnCat
requested changes
Jun 15, 2023
There was a problem hiding this comment.
Hey @louis-e, thanks for your contribution. It already looks great, although I have one minor change I need you to apply before I can merge it. (See attached comment)
It seems the automatic linter has gone a bit haywire, so don't mind the failed action on the PR - This is not related to your PR and I'm looking into fixing it!
|
Alright, thanks for the notice! I also removed the unnecessary source code reference in the previous line (PraxisMapper). |
|
Great! Thanks for the addition (and the fix of the line above 😄). Your project is really awesome and will fit right in on the list 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arnis is a Python project using OSM to generate cities from real life in Minecraft - experimental, but might be interesting enough to be added to the list :)