Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PCRS 5cm imagery WMTS source for metropolitan France #1696

Merged
merged 3 commits into from
May 22, 2023
Merged

Add PCRS 5cm imagery WMTS source for metropolitan France #1696

merged 3 commits into from
May 22, 2023

Conversation

flacombe
Copy link
Contributor

@flacombe flacombe commented Dec 7, 2022

Dar maintainers,

I propose to add a new 5cm imagery source for metropolitan France

GetCapabilities is here to check proposed layer: https://wxs.ign.fr/ortho/geoportail/wmts?SERVICE=WMTS&VERSION=1.0.0&REQUEST=GetCapabilities

Best regards

rbuffat
rbuffat reviewed Dec 10, 2022
View reviewed changes
sources/europe/fr/PCRS.geojson Outdated
"available_projections": [
"EPSG:2154"
],
"license_url": "https://www.etalab.gouv.fr/licence-ouverte-open-licence/",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license_url should point to a website that specifies the license of the data, not the license itself. E.g. ideally on the site linked here, it should say dataset PCRS rasters has license X.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I only know https://geoservices.ign.fr/pcrs which isn't clear regarding the license.

Be sure I'll ask to complete it with appropriate mention next week.
All imagery from IGN/public services is Etalab/Open Licence v2 actually.

@rbuffat
Copy link
Collaborator

rbuffat commented Dec 10, 2022

@flacombe Thanks for your PR! Would it be possible for you to answer the questions I asked above?

@flacombe
Copy link
Contributor Author

Hi @rbuffat, it's all done now, thank you for interest

@flacombe
Copy link
Contributor Author

Hello

I don't understand the warning provided with the check log.
I don't use any LinearRing geometry... where is it?

@rbuffat
Copy link
Collaborator

rbuffat commented Jan 17, 2023

@flacombe I will try to have a look at it during the next few days!

rbuffat
rbuffat reviewed Mar 22, 2023
View reviewed changes
sources/europe/fr/PCRS.geojson Show resolved Hide resolved
sources/europe/fr/PCRS.geojson Outdated Show resolved Hide resolved
@rbuffat
Copy link
Collaborator

rbuffat commented Mar 22, 2023

@flacombe I'm very sorry, it took a lot longer for me to look at it as I originally planned.

Using google I found the following link regarding the license situation: https://docs.pcrs.beta.gouv.fr/usages/contribution-openstreetmap
It would be much appreciated if somebody more familiar with the situation in France could have a look at it. Maybe @grischard or @don-vip ?

I have to say I'm a bit confused. From the name "Plan Corps de Rue Simplifié" I would assume that the service would contain vector data, but it looks to be aerial images.

@flacombe
Copy link
Contributor Author

Hi @rbuffat

Using google I found the following link regarding the license situation: https://docs.pcrs.beta.gouv.fr/usages/contribution-openstreetmap

I'm the author of this web page :)
The licence is granted by the French opendata general lawful framework
https://www.legifrance.gouv.fr/codes/article_lc/LEGIARTI000044403448

As stated by
https://ghost.pcrs.beta.gouv.fr/content/files/2023/01/AGD-Saisine-ANCT-PCRS-20230124.pdf

I have to say I'm a bit confused. From the name "Plan Corps de Rue Simplifié" I would assume that the service would contain vector data, but it looks to be aerial images.

PCRS is divided into two main data formats: raster and vector.
The raster part can be used as background aerial imagery suitable for OSM and the vector could be directly imported or used in quality control at least, when available (still no opendata currently).
https://docs.pcrs.beta.gouv.fr/contexte-reglementaire/geostandards#vecteur-et-raster

Let me know if those further resources can be suitable for license grant.

Best regards

Marc-marc-marc added a commit to Marc-marc-marc/editor-layer-index that referenced this pull request May 22, 2023
@Marc-marc-marc
Update Volta.geojson
e74e75f 
update text(url Enedis -> Agence ORE
splitted from osmlab#1696
@Marc-marc-marc Marc-marc-marc mentioned this pull request May 22, 2023
Merged
Marc-marc-marc added a commit that referenced this pull request May 22, 2023
@Marc-marc-marc
Update Volta.geojson (#1872)
2f62140 
update text(url Enedis -> Agence ORE
splitted from #1696
@Marc-marc-marc Marc-marc-marc merged commit e523420 into osmlab:gh-pages May 22, 2023
@Marc-marc-marc
Copy link
Collaborator

@flacombe adding privacy_policy_url could be usefull, I also have splitted change for Volta map style in another PR to make this RP more readable

@jthiard jthiard mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbuffat rbuffat rbuffat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flacombe @rbuffat @Marc-marc-marc