IndianaMap

[1ec5]

Added the three WMSes for IndianaMap orthoimagery. Note that the 2018 geometry covers more counties than the WMS currently provides; these additional counties will be added to the 2018 MapServer sometime this year.

Fixes #686.

[1ec5]

Added to JOSM.

[grischard]

Hi Minh,

On one hand, it looks like I'm the one to blame for not having CI tools that caught that you were trying to add a Multipolygon, which isn't supported. I thought check.py was supposed to catch this.

On the other hand, you didn't wait for feedback, you merged quickly and on a weekend, and used a Multipolygon while the documentation says to use a Polygon.

Can you please fix your PR to use a Polygon geometry instead of Multipolygon? And I'll try to see why check.py didn't catch this.

[1ec5]

Sorry for jumping the gun. Would it be possible to use a feature collection instead? Unfortunately, all three layers have discontiguous coverage areas. If not, I can try to draw a very thin line connecting the polygons.

[1ec5]

Looks like the validation script only checks whether the type can be compared to the string Polygon, not whether it’s equal to that string:

editor-layer-index/scripts/check.py

Lines 127 to 130 in e3b91ea

	try:
	source['geometry']['type'] == "Polygon"
	except (TypeError, KeyError):
	raise ValidationError("{} should have a valid geometry or be global".format(filename))

[1ec5]

#697 fixes the bug in the validation script.

[grischard]

The usual, admittedly unfamiliar, for-historical-reasons way to do it is to have a simple polygon with more than one ring. Look at the France geojsons with Corsica for example.

[grischard]

Did you see #694 too?

You should play the lottery 😄