Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all missing OpenRailwayMap overlays #720

Merged
merged 3 commits into from Mar 3, 2020
Merged

Add all missing OpenRailwayMap overlays #720

merged 3 commits into from Mar 3, 2020

Conversation

hikemaniac
Copy link
Contributor

This pull request adds the OpenRailwayMap Maxspeed overlay and the OpenRailwayMap Signalling overlay.

@hikemaniac hikemaniac changed the title Added all missing OpenRailwayMap overlays Add all missing OpenRailwayMap overlays Oct 9, 2019
@grischard
Copy link
Collaborator

Good idea, thanks!

Are we even allowed to use these actually? I couldn't find anything on the website, and there are no license attributes.

Can you please add the privacy policy at https://www.openrailwaymap.org/en/imprint ?

Would it also be possible to have better descriptions for the layers?

@hikemaniac
Copy link
Contributor Author

@grischard I just added the privacy policy URL and a better description. Thank you for pointing that out. 👍

Since the data on the overlay comes directly from OpenStreetMap, I presume that we are allowed to use the layers. The infrastructure OpenRailwayMap layer has been in the index since 2018 and it came from the JOSM layer index, therefore I am positive that the license is OSM-compatible for all the other layers of OpenRailwayMap as well. On the website, the attribution text always remains the same regardless of the layer, so the terms should also be exactly the same.

@grischard
Copy link
Collaborator

I wouldn't want to add it without their permission, even if just to make sure we won't hammer the servers. See OpenRailwayMap/OpenRailwayMap#88 - it's been a know issue for a while.

@grischard
Copy link
Collaborator

@Nakaner did you mention that you'd updated a wiki page somewhere that would fit?

@grischard
Copy link
Collaborator

https://wiki.openstreetmap.org/wiki/OpenRailwayMap/API#Terms_of_use is the wiki page that allows usage.

@grischard grischard merged commit 6b075a7 into osmlab:gh-pages Mar 3, 2020
@grischard
Copy link
Collaborator

Thank you @hikemaniac !

bhousel added a commit to rapideditor/imagery-index that referenced this pull request Mar 6, 2020
@hikemaniac hikemaniac deleted the openrailwaymap branch March 7, 2020 17:30
@maro-21
Copy link

maro-21 commented Apr 29, 2020

Could you please correct it to make it translatable?

@hikemaniac
Copy link
Contributor Author

@maro-21 Thanks for the suggestion, I created a PR for this in #832. 👍

@maro-21
Copy link

maro-21 commented May 1, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants