-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When editing the Challenge, do not rebuild tasks #573
Comments
Alternatively, instead of disabling the functionality entirely, a switch could be added to rebuild after editing. |
I think this is no longer done when you press the 'finish' button after editing. @nrotstan correct? (if so please close :)) |
I got the issue today with a remote GeoJSON file : it rebuild all my tasks when I just changed the "Challenge Basemap". (ping @nrotstan) |
Thanks for the feedback, @jbelien . I recommend making sure your tasks have some kind of unique id property so that they don't get duplicated on rebuilds. You can read more about that on the Learn site. In the mean time, you can try doing another rebuild ("Rebuild Tasks" button) and choosing the option to first delete all incomplete tasks, which will hopefully remove your dups. As far as this specific issue is concerned, we've gotten better, but some changes do still result in unnecessary rebuilds. Typically this is an inconvenience, though, rather than an outright problem. |
Good to know ; I'll check if I could implement that easily.
Yes, definitely not an issue, I already did that twice. 👍 |
This also bit me. Could there be an option to generate the unique IDs based on the geojson attributes, including coordinates? |
You mean some sort of hash based on the location and properties combined? I think theoretically that could be done. However, I wouldn't want to take the option to have your own unique IDs away from the user. So it would need to be a fallback. We'll look into this more, but in the mean time, let's see if we can do a better job educating the user about the importance of having unique identifiers for your tasks. |
When I make a small edit to a challenge, say a typo in the description, I do not want MR to rebuild the tasks necessarily. This can take a long time and incur unnecessary load on Overpass as well as the MR server. Also not needed since we have separate 'rebuild' option.
The text was updated successfully, but these errors were encountered: