Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing the Challenge, do not rebuild tasks #573

Closed
mvexel opened this issue Dec 11, 2018 · 7 comments
Closed

When editing the Challenge, do not rebuild tasks #573

mvexel opened this issue Dec 11, 2018 · 7 comments

Comments

@mvexel
Copy link
Member

mvexel commented Dec 11, 2018

When I make a small edit to a challenge, say a typo in the description, I do not want MR to rebuild the tasks necessarily. This can take a long time and incur unnecessary load on Overpass as well as the MR server. Also not needed since we have separate 'rebuild' option.

@rivermont
Copy link

Alternatively, instead of disabling the functionality entirely, a switch could be added to rebuild after editing.
I would argue that it should be turned off by default as minor edits that don't require a rebuild are likely more common than those that do.

@mvexel
Copy link
Member Author

mvexel commented Jul 25, 2019

I think this is no longer done when you press the 'finish' button after editing. @nrotstan correct? (if so please close :))

@jbelien
Copy link

jbelien commented Oct 21, 2020

I think this is no longer done when you press the 'finish' button after editing.

I got the issue today with a remote GeoJSON file : it rebuild all my tasks when I just changed the "Challenge Basemap".
That's a bit problematic since all the tasks are duplicated because of that.

(ping @nrotstan)

@nrotstan
Copy link
Contributor

Thanks for the feedback, @jbelien . I recommend making sure your tasks have some kind of unique id property so that they don't get duplicated on rebuilds. You can read more about that on the Learn site.

In the mean time, you can try doing another rebuild ("Rebuild Tasks" button) and choosing the option to first delete all incomplete tasks, which will hopefully remove your dups.

As far as this specific issue is concerned, we've gotten better, but some changes do still result in unnecessary rebuilds. Typically this is an inconvenience, though, rather than an outright problem.

@jbelien
Copy link

jbelien commented Oct 21, 2020

I recommend making sure your tasks have some kind of unique id property so that they don't get duplicated on rebuilds. You can read more about that on the Learn site.

Good to know ; I'll check if I could implement that easily.

In the mean time, you can try doing another rebuild ("Rebuild Tasks" button) and choosing the option to first delete all incomplete tasks, which will hopefully remove your dups.

Yes, definitely not an issue, I already did that twice. 👍

@grischard
Copy link

This also bit me.

Could there be an option to generate the unique IDs based on the geojson attributes, including coordinates?

@mvexel
Copy link
Member Author

mvexel commented Dec 28, 2020

You mean some sort of hash based on the location and properties combined? I think theoretically that could be done. However, I wouldn't want to take the option to have your own unique IDs away from the user. So it would need to be a fallback.

We'll look into this more, but in the mean time, let's see if we can do a better job educating the user about the importance of having unique identifiers for your tasks.

@mvexel mvexel closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants