Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning cleaning (and registering/deletion of warning causing instances #1943

Merged
merged 11 commits into from
Oct 18, 2018

Conversation

good-praxis
Copy link
Collaborator

Decided to clean up a bunch of warnings (7)

No issue for bancpost
No wikipedia page for Banco Unión (but it seems to be a real brand)

Café Central's wikidata ID is actually just the ID of a single specific historical café.

Kroger is the correct name, even though Kroger Fuel had a higher count (according to wikipedia / image search, too)

Liberty does not yet have a wikipedia page, but is mentioned here

@matkoniecz
Copy link
Contributor

In general in cases like this it is easier to review PR for each issue, as any issue blocks merging of everything else.

Though note that it is this way for me and others may have different preferences (or the same).

Café Central's wikidata ID is actually just the ID of a single specific historical café.

Thanks, thanks for catching that!

Are you sure that all

amenity/bureau_de_change|Western Union

are mistagged and should be rather

amenity/bank|Western Union

Are you sure that there is no real difference between

amenity/fuel|Esso

and

amenity/fuel|Esso Express

Are you sure that there is no real difference between

amenity/fuel|Kroger Fuel

and

amenity/fuel|Kroger

?

@matkoniecz
Copy link
Contributor

All other changes look OK for me, ones mentioned above is where I am not sure.

@good-praxis
Copy link
Collaborator Author

good-praxis commented Oct 18, 2018

Western Union

Well, technically Western Union is neither a bank nor a bureau de change, but they offer services similar to both. (this isn't entirely true, in Germany, Austria and France WU is actually registered as a bank, this is probably because of local regulation demanding this for their services), in reality, WU is closer to something like Paypal -- do we have a financial services tag?

Esso (Express)

Esso Express similar to other "Express" brands appear in the Netherlands, usually because of localization. It may be better to add Netherland localized version with "Express" within the brand, however, Esso Express isn't a distinct version of Esso, and it may be that not all Esso's in the Netherlands are Esso Express' -- they are, however, not distinct gas stations

Kroger

Kroger gas stations are usually called just that. Kroger websites are also devoid of any mentioning of "Kroger Fuel" as a distinct brand

@matkoniecz
Copy link
Contributor

Western Union

Are there locations operating under Western Union offering only currency exchange, without banklike services?

Esso (Express)

In that case I think that keeping both names may be a better idea (maybe with the same brand, brand:wikipedia, brand:wikidata values).

Kroger

In that case I am OK with that.

@matkoniecz matkoniecz closed this Oct 18, 2018
@matkoniecz matkoniecz reopened this Oct 18, 2018
@matkoniecz
Copy link
Contributor

Sorry for misclick, I wanted to comment only.

@good-praxis
Copy link
Collaborator Author

Western Union:

I find it highly unlikely, however not impossible. It'd be against their buisness model, which is mainly focused on international transactions without a bank account. I can revert that commit, too, if necessary.

Esso

How about that?

@matkoniecz
Copy link
Contributor

It'd be against their buisness model, which is mainly focused on international transactions without a bank account.

It makes sense.

Let's merge it - thanks for your fixes!

@matkoniecz matkoniecz merged commit c09435c into osmlab:master Oct 18, 2018
@matkoniecz
Copy link
Contributor

Feel free to propose reverted ones as separate PRs if you think that I was too cautious.

@bhousel
Copy link
Member

bhousel commented Oct 18, 2018

No issue for bancpost
No wikipedia page for Banco Unión (but it seems to be a real brand)

Café Central's wikidata ID is actually just the ID of a single specific historical café.

Kroger is the correct name, even though Kroger Fuel had a higher count (according to wikipedia / image search, too)

Liberty does not yet have a wikipedia page, but is mentioned here

This is good research - but make sure to link back to the original issues so it doesn't get lost!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants