Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplication of Western Union and add brand:wikidata, brand:wikipedia #2136

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Fix duplication of Western Union and add brand:wikidata, brand:wikipedia #2136

merged 2 commits into from
Oct 25, 2018

Conversation

NMVikings
Copy link
Contributor

No description provided.

@matkoniecz
Copy link
Contributor

Is it certain that amenity=bank is always preferred over amenity=money_transfer, for all countries? For example in Africa?

@NMVikings
Copy link
Contributor Author

I think, that Western union is money transfer firm, but I didn't find money_transfer on https://wiki.openstreetmap.org/wiki/Map_Features. That's why i chose amenity=bank.

Quote from Wikipedia

Western Union has several divisions, with products such as person-to-person money transfer, money orders, business payments, and commercial services.

@good-praxis
Copy link
Collaborator

Yeah, this is kind of the same discussion that we had in #1943 about WU @matkoniecz
Technically WU only operates with a bank license in a few countries in europe, and probably only for regulations.

However I think there will be places where it only allows money transfer. That's their main buisness, afterall. But maybe this is close enough to a bank?

@good-praxis good-praxis added the question Not Actionable - just a question about something label Oct 24, 2018
@matkoniecz
Copy link
Contributor

https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dmoney_transfer is also documented, with Western Union as an example.

@matkoniecz
Copy link
Contributor

I think that we may need to keep both entries - Wester Union as a bank and as a money transfer.

@NMVikings
Copy link
Contributor Author

But there is match between them. They aren't different organisations.

@maxerickson
Copy link
Collaborator

Different faces of the same organization can need different modeling though.

In the US, Western Union usually is available at a service counter in a different business and doesn't really exist as an independent location/business.

@matkoniecz
Copy link
Contributor

But there is match between them. They aren't different organisations.

Tesco operates fuel station and supermarkets. They share the same brand but are otherwise tagged differently.

There is no reason to tag Western Union as a bank in places where it is not one (not, I am not 100% sure whatever amenity=money_transfer should be promoted, but at least it is used).

@bhousel bhousel merged commit 6f65c03 into osmlab:master Oct 25, 2018
@bhousel
Copy link
Member

bhousel commented Oct 25, 2018

I think that we may need to keep both entries - Wester Union as a bank and as a money transfer.

This is what I did in b3507c7.. We can just include both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Not Actionable - just a question about something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants