adding 'brand' data from Dohánybolt #2009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENT8R
reviewed
Oct 19, 2018
config/canonical.json
Outdated
| "tags": { | ||
| "brand": "Nemzeti Dohánybolt", | ||
| "brand:wikidata": "Q20639040", | ||
| "brand:wikipedia": "en:Dohánybolt", | ||
| "countryCodes": ["hu"], |
There was a problem hiding this comment.
This has to be below the count tag...
There was a problem hiding this comment.
the "countryCode" tag?
There was a problem hiding this comment.
Yes, this does not belong into the "tags" object... it should look like this:
"shop/tobacco|Nemzeti Dohánybolt": {
"count": 877,
"countryCodes": ["hu"],
"match": [
"shop/tobacco|Dohánybolt",
"shop/tobacco|Nemzeti dohánybolt"
],
"tags": {
"brand": "Nemzeti Dohánybolt",
"brand:wikidata": "Q20639040",
"brand:wikipedia": "en:Dohánybolt",
"name": "Nemzeti Dohánybolt",
"shop": "tobacco"
}
},
|
BTW: Google translates it directly to tobacco shop (https://translate.google.de/#auto/en/doh%C3%A1nybolt) Are you sure that this is no generic name after all? |
|
It is kind of generic. Expect for the fact that they're all state run, so the same actor is behind them, just like a commerical brand. However, this is probably worth a bigger debate |
|
This is old, so I'm just going to do what @ImreSamu suggested here: |
bhousel
added a commit
that referenced
this pull request
Mar 3, 2019
(closes #1811, closes #2009) (see #2028 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1811
source