Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiger mart (ExxonMobil) #2110

Merged
merged 2 commits into from
Oct 24, 2018
Merged

tiger mart (ExxonMobil) #2110

merged 2 commits into from
Oct 24, 2018

Conversation

eczajk1
Copy link

@eczajk1 eczajk1 commented Oct 22, 2018

Resolves #1303

"Tiger Marts" are associated with ExxonMobil brand gas stations, such as the one mapped in this vicinity.

Added Wikipedia and Wikidata entries for Exxon.

good-praxis
good-praxis requested changes Oct 22, 2018
View reviewed changes
Copy link
Collaborator

@good-praxis good-praxis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly think this data is too low quality. Let's run it by @bhousel for best practices before we merge!

@good-praxis good-praxis mentioned this pull request Oct 22, 2018
Open
@eczajk1
Copy link
Author

eczajk1 commented Oct 22, 2018

Here's an article that mentions Tiger Mart being associated with Exxon Mobile: https://csnews.com/top-10-chains

They are often co-located with Exxon Gas Stations. But, this one seems to be next to an "Esso" station. Esso and Exxon are both Exxon Mobile brands.

@good-praxis
Copy link
Collaborator

Yeah, it's not that I don't trust your research, it's just that the wikidata/wikipedia data is very low quality, and may not be suitable for our purposes! 😄 But we'll see!
Thanks for the PR though

@bhousel
Copy link
Member

bhousel commented Oct 22, 2018

Ooo yeah it would be a little better if Tiger Mart had its own Wikidata and Wikipedia entries.

It is actually listed here, but not linked to a page:
https://en.wikipedia.org/wiki/List_of_convenience_stores

@good-praxis good-praxis added the needs wikidata It is necessary to create a wikidata entry label Oct 22, 2018
@good-praxis
Copy link
Collaborator

@eczajk1 I created Q57643977 for this. So just remove the wikipedia article and use that Wikidata ID instead

@good-praxis good-praxis merged commit 10da979 into osmlab:master Oct 24, 2018
@eigenbrot eigenbrot mentioned this pull request Oct 26, 2018
Merged
@bhousel bhousel mentioned this pull request Dec 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@good-praxis good-praxis good-praxis approved these changes

Assignees
No one assigned
Labels
needs wikidata It is necessary to create a wikidata entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eczajk1 @good-praxis @bhousel