Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more bancos #2220

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Add more bancos #2220

merged 1 commit into from
Dec 27, 2018

Conversation

Adamant36
Copy link
Collaborator

@Adamant36 Adamant36 commented Dec 27, 2018

closes #203, closes #207, closes #209, closes #214, closes #216, closes #219, closes #220, closes #227, closes #229, closes #233, closes #234, closes #235, closes #241, closes #254, closes #262.

If you don't mind me asking, what do you do with multiple entries that are the same company but different names or ones that don't have any Wikipedia page?

@bhousel
Copy link
Member

bhousel commented Dec 27, 2018

Thanks @Adamant36!

what do you do with multiple entries that are the same company but different names

It depends on whether they are really different enough. For example, this index contains separate entries for "Walmart" and "Walmart Supercenter" and "Walmart Market" - they are all the same company but different things are sold in each of them.

However we merged together into a single entry "Hampton Inn" and "Hampton Inn and Suites" because as far as we could tell, they are the same thing. see #2065

or ones that don't have any Wikipedia page?

As long as it has wikidata, it's ok to add it here. If the brand doesn't yet have a wikidata page, we create an issue in GitHub and tag it with "needs wikidata", until someone adds the wikidata page for it. This is really easy for anyone to do, but not everyone is comfortable adding it. see #2110

Also see #2099 for a bunch of other good questions that have come up - I really need to make a FAQ!

@Adamant36
Copy link
Collaborator Author

Your welcome. Thanks for the information. A FAQ would be really helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment