Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to fetch logos for all the Wikidata-tagged brands..
see #2116
npm run logos
to run itconfig/secrets.json
(this file is .gitignore'd)brand:wikidata
tag to lookup the following properties from Wikidata:facebook
)"logos": {}
object on each brand entry.This is kind of great too because: the way to add more logos is to just update Wikidata with the brand social media account, and run the script again. We are making Wikidata better!
I'd really like to merge this and make the logos available in iD, so that the users see them as they are assigning a brand preset.
Would love to hear people's thoughts!