Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the remaining common Marriott brands #3091

Merged
merged 26 commits into from
Oct 28, 2019
Merged

Add the remaining common Marriott brands #3091

merged 26 commits into from
Oct 28, 2019

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Oct 9, 2019

Wow they have a lot of brands. I think this adds all the major ones and cleans up some bad brand vs company issues + restrictive country codes.

I also split out Fairfield Inn and Fairfield Inn & Suites. This one is total mess. They appear to be rebranding the whole lineup, but depending on what type of location and where you are it's either Fairfield by Marriott, Fairfield Inn, or Fairfield Inn & Suites. Hopefully they rebrand them all in the next few years and we can fix it, but this is close enough for now and allows folks to continue to distinguish the suite variant.

Signed-off-by: Tim Smith tsmith@chef.io

Copy link
Member

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up these entries! Hopefully we can avoid repurposing QIDs as much as possible. By ensuring that brand:wikidata can stand on its own unambiguously, we maximize the tag’s utility for data consumers other than editor validators.

brands/tourism/hotel.json Outdated Show resolved Hide resolved
brands/tourism/hotel.json Outdated Show resolved Hide resolved
brands/tourism/hotel.json Outdated Show resolved Hide resolved
brands/tourism/hotel.json Show resolved Hide resolved
brands/tourism/hotel.json Show resolved Hide resolved
brands/tourism/hotel.json Show resolved Hide resolved
brands/tourism/hotel.json Show resolved Hide resolved
brands/tourism/hotel.json Outdated Show resolved Hide resolved
@bhousel
Copy link
Member

bhousel commented Oct 16, 2019

I didn't get a chance to look too closely at this, but whatever you want to do is fine with me.. 👍

@bhousel bhousel requested review from 1ec5 and removed request for bhousel and Adamant36 October 16, 2019 18:05
@tas50
Copy link
Contributor Author

tas50 commented Oct 16, 2019

I still need to carve out some time to double check my own thoughts here on some of the brands. The entire hotel industry is in the middle of a rebranding with the recent mergers and it makes this tricky. So many brands are using 2 or 3 different names for the same brand.

@bhousel
Copy link
Member

bhousel commented Oct 16, 2019

The entire hotel industry is in the middle of a rebranding with the recent mergers and it makes this tricky. So many brands are using 2 or 3 different names for the same brand.

It really is pretty wild. I look through our hotel list and wonder like.. are the hotels ok? Why are they doing this? Nobody else does this - everyone else consolidates little brands into big ones like it's a winner-take-all competition.

I would love it if someone someday finds NSI and OSM useful to research business trends like this.

@tas50
Copy link
Contributor Author

tas50 commented Oct 19, 2019

I made a few tweaks to this. Thanks for the detailed review @1ec5. I'll make a few more updates to the IDs and double check this brand mess everyone is in the middle of.

brands/tourism/hotel.json Outdated Show resolved Hide resolved
brands/tourism/hotel.json Outdated Show resolved Hide resolved
brands/tourism/hotel.json Outdated Show resolved Hide resolved
brands/tourism/hotel.json Outdated Show resolved Hide resolved
brands/tourism/hotel.json Outdated Show resolved Hide resolved
brands/tourism/hotel.json Outdated Show resolved Hide resolved
brands/tourism/hotel.json Outdated Show resolved Hide resolved
brands/tourism/hotel.json Outdated Show resolved Hide resolved
brands/tourism/hotel.json Outdated Show resolved Hide resolved
Wow they have a lot of brands. I'm going to see if I can track down more specific wikidata / wikipedia entries for them, but they're all owned by Marriott so using that wikidata is better than nothing. I also fixed the courtyard entry to match the name field and updated delta -> delta hotels since that's the signage and the brand naming the Marriott uses.

Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
This is from their website

Signed-off-by: Tim Smith <tsmith@chef.io>
Let's not limit this to CA / US

Signed-off-by: Tim Smith <tsmith@chef.io>
From their website

Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
These hotels are named Renaissance CITY not Renaissance Hotel CITY.

Signed-off-by: Tim Smith <tsmith@chef.io>
Over 100 locations all over the world.

Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
They're not in OSM worldwide, but they exist

Signed-off-by: Tim Smith <tsmith@chef.io>
As they rebrand into the US it'll be important that both work in search.

Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
tas50 and others added 10 commits October 27, 2019 18:35
Signed-off-by: Tim Smith <tsmith@chef.io>
Co-Authored-By: Malcolm Smith <malcolmsmith18@gmail.com>
Co-Authored-By: Malcolm Smith <malcolmsmith18@gmail.com>
Co-Authored-By: Malcolm Smith <malcolmsmith18@gmail.com>
Co-Authored-By: Malcolm Smith <malcolmsmith18@gmail.com>
Co-Authored-By: Malcolm Smith <malcolmsmith18@gmail.com>
Co-Authored-By: Malcolm Smith <malcolmsmith18@gmail.com>
Co-Authored-By: Minh Nguyễn <mxn@1ec5.org>
Co-Authored-By: Minh Nguyễn <mxn@1ec5.org>
Co-Authored-By: Minh Nguyễn <mxn@1ec5.org>
Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 merged commit fe2da07 into master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants