-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diet:vegetarian to some fast food brands. #4855
Conversation
Adding diet:vegetarian to brands that have a vegetarian option.
Thanks @Eric-Sparks There seems to be a random "Tr" floating around within the "A&W (USA)" entry, which is causing a build fail, any reason for this? |
Overall a good idea. I think there's one problem here which is that many of these brands have different menus world wide. For example while lots of restaurants have lots of vegetarian options for the Indian market the German market isn't as likely to have vegetarian options. |
Umm, no? Didn't think I changed anything with A&W. |
I feel pretty weird about this - That would cover almost all restaurants and fast food, right? |
So not all restaurants and fast food have a proper vegetarian option available. Offering a salad doesn't automatically make it a diet:vegetarian=yes. Think about Chipotle where you can get a full meal like a burrito with beans, guacamole, lettuce, and tomatoes. From the OSM wiki:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some suggestions to change diet:vegetarian
to diet:vegan
based on chains I know have vegan friendly options or quick substitutions.
As to whether this is worth it, I think so. It's definitely subjective as to whether the tag is warranted, I wouldn't add it for a place that just had french fries but I would for a burger restaurant that offers a meat-free patty. I usually stick to vegan tags since vegan-friendly menus are a bit less ubiquitous than vegetarian ones and that tag encompasses vegetarian. It helps power OpenVegeMap which is an open alternative to things like HappyCow and until recently Google Maps/Yelp/etc didn't have reliable searching options for "Vegan". There's an active telegram where people talk about this as well.
I wouldn't substitute vegan for vegetarian due to the way some searches may work but I'd totally add it. Co-authored-by: Ariel Kadouri <ariel@arielsartistry.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, okay, I clearly do better when just using git in a command-line environment...
So, I wouldn't change vegetarian to vegan due to the way some searches may work but I'd totally add diet:vegan=yes to those chains that support vegan.
Still feeling pretty unsure about this PR. For example this change: This means:
This might be technically correct - I don't know - but it would surely be confusing and suspicious for users. If iD prompted me to make this change, I'd think something was wrong. A good way to think about the name-suggestion-index is that we shouldn't add any tags to this index that we wouldn't also be comfortable making to the OSM with a mass edit. I'm very ok with updating tags like |
That makes sense, rethinking about it as a mass edit I don't know if I'd still make the change unless it was a core part of the chain (the |
I felt this was important because it is sometimes difficult to find vegetarian options in the sea of restaurants that are out there. Not all restaurants offer good vegetarian options. The restaurants I selected specifically say they offer vegetarian options *as a brand*. I think this is a good opportunity to start adding these dietary options to the map.
|
@Eric-Sparks - I've been thinking about this more.. What if we added another property like I agree with you that it's useful information to track somewhere, my biggest concern is just that adding them all en masse to OSM would be seen badly by some mappers. A project that wants to know which brands have vegan offering could still use this index to say "If I match White Castle, I can imply that they offer vegan food". Or you could make/use/release your own distribution of OSM that has the implied tags already merged in? |
that might be quite usefull but in my opinion more for values which conflict with that implied tag
Yup probably not a good idea
Do you mean that as a general value for each catergory or for each entry on it's own ? |
I'm not sure why you wouldn't want to add this information automatically?
Why would this be seen as bad by some mappers? What am I missing here? Adding diet:vegetarian to a restaurant is not new to OSM and has been used more than 30,000 times around the world. If a brand is openly advertising vegetarian options then it would seem like an easy thing to do to add this to their brand which then helps the millions of people that are looking for this information on the streets. Clearly there is a problem here that I'm not understanding as this seems to be rather straight forward. |
Generally I would agree with you as it relates to this, but there are times when a brand will not necessarily have an entire menu available at every restaurant, which is sometimes marked as "at participating restaurants" or in White Castle's case "at participating Castles". That being said, I wouldn't have any objection to the NSI listing "diet:*" based on a brands menu, as I think that is a general indication that it's likely to be available, and I can't imagine any restaurant or franchisee would remove that type of menu selection in full from the brand menu. |
I'd imagine a |
#5006 is fine - there's a big difference between adding |
{{vote|no}} Is it necessary to keep this Pull Requests still open? This pr has already been pending for 8 months, and still have something controversial such as adding |
Well, this really shouldn't have been controversial. These restaurants are advertising having vegetarian options (not necessarily vegan, by the way, as this PR morphed into). I'm just trying to make it easier for vegetarians to find appropriate places to eat.
|
I'm ok with this PR staying open because I think it's a reasonable request, but I think tags like this should be in an |
I agree with you, but if you were to ask any of the regular OSM channels (tagging mailing list, slack, discord, etc) and propose a mass edit to |
That will be a better way. |
(until #4855 is resolved we shouldn't do this)
Sort of linked to this, and also It seems a bit safer to me than assuming a diet type will be available at all pubs from a brand, and I can't imagine a pub brand wouldn't have ANY food available in some establishments (given even the airport Wetherspoons serve food). Plus a bit like the takeaway aspect tagged on other food establishments, it's an important and relevant aspect of them. |
I kind of disagree with this..
(as an aside, I sort of think the |
Yeah, we sort of got caught up with what is food, see streetcomplete/StreetComplete#3099 and https://lists.openstreetmap.org/pipermail/tagging/2021-July/062106.html onwards... So tagging food=yes where we know there definitely would be would work around it for some places, without having to answer the awkward question? See also https://en.wikipedia.org/wiki/Substantial_meal !
How so? A posh afternoon tea place is going to be |
Can we please get back on track with the original intent of this pull request? There are people out there that have dietary restrictions that are looking for ways to find food easily. When a brand openly advertises that they offer a vegetarian, or whatever, option, I think we should add that to the brand to help those with dietary restrictions find food. These places are mostly cookie-cutter where each place is going to offer the exact same food so there is no need to have each restaurant surveyed to determine if they serve the dietary option or not. There has been a lot of speculation as to what "people" might say if you asked on a particular communications medium. I say that if there are people against such a proposal then they aren't thinking about the users out there that would actually use the data to obtain, you know, FOOD. Of course, no one has actually asked these "people", not that it really matters. This really isn't a huge deal and I'm not sure why people are making more of this than it has to be. |
Hey I was linked across to this PR as I was making a change to a local brand who when checking all regional menus would have vegetarian and vegan options. I totally understand the point you're making here @bhousel, it's a fine line to make sure people don't discount this index. For the implied tags feature, do you imagine there will be any integration with editors to help recommend the tag be applied? Perhaps a two step approach, first apply the tags, then offer some additional tags? I understand you can't speak for every editor but just your best guess. At least for me, the only reason it would be interesting adding these tags to this index, would be to increase the usage of these tags across the map. Where this would help OpenVegeMap really flesh out it's data without needing significant investment or understanding by the editor about the nuance of this tag and our discussion right now. Excited to hear your thoughts 🙂 |
I'm closing this as stale and probably not mergeable with how things currently are anyway. To quote a comment from another issue, "f it's an "attribute tag" that is true for every instance of this thing in OSM, there isn't a lot of value in actually adding it to every instance of the thing in OSM, and it just makes extra work for mappers if that attribute ever changes." Feel free to re-open this if anything changes about this in the future though 👍 |
I've been adding the diet:vegetarian tag to some local restaurants but, according to the brand's website, these places universally have vegetarian options.