-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only ask about vegan and vegetarian diet for pubs serving food, not all pubs #3099
Conversation
Pending discussion in https://lists.openstreetmap.org/pipermail/tagging/2021-July/062106.html Although seemingly even this is a little controversial for the food=yes/no quest at least... |
or diet:vegetarian ~ yes|only and | ||
( | ||
amenity ~ restaurant|cafe|fast_food | ||
or amenity = pub and food != no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be food=yes
, not food != no
. Otherwise this is also asked if food
is missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would food and food != no
work? There are currently 348 values which aren't no but appear to be positive/true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but are you sure that those values are/would be used on amenity=pub
? Is maybe the food
key also used in another context?
(food and food != no
would work from technical perspective)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pizza, which looked like the most popular likely value, has four hits, when I do a query; restaurant has 7. So aren't we better off including them too? Even if they weren't used on pub now, presumably they'd show up in iD and whatever as suggestions when you used the food tag, so they might get added if they weren't present already.
From what I have read so far, not that much. If has been noted that it should be clear what is food and what is not and so far people said that snacks are not food, so I'd go with that definition, i.e. a quest of that sort should make it clear that crisps and nachos don't count. |
I also realised this doesn't block this PR being merged as such, it just makes it a bit ineffective on it's own.
Personally I'd say nachos, when coated with cheese and guacamole and chilli would, but I guess that's the somewhat subjective bit. I think we're all in agreement about crisps/potato chips and pork scratchings being out anyway. Incidentally, I think part of the issue is inconsistency like this: |
On what counts as food... maybe it would make sense to let the user answer when asked proper food | just snacks | nothing with the first being |
Yeah that would certainly help make clear what they meant.
I almost wonder if the second one should be |
hmm... there is a problem with that. That would mean that
Almost 90% of this so far not that much tag has the value of either "no" or "yes". |
Ah yes, you'd then need a whole set of values for levels of food such as nibbles, snacks, full, banquet with all the confusion about where something falls which that would entail. Although equally it does seem a bit odd to me if we end up with tagging:
Whereas something like this seems better from a logical point of view:
Yes, I agree they could certainly be tagged in better ways, however none of them (even Then a separate food quest could fix up the cuisine mis-tagging, or just retag as But I'm rambling, my main point regarding #3099 (comment) is we should therefore accept a broad church of mistagging or creative tagging for this particular quest (and fix it in a future food one). |
Let's just accept food=yes |
because
We don't know what these values mean. Not documented. We can only assume. And note, that places where |
Thanks @westnordost , sorry I was away when you replied and I've only just got back so thanks for fixing and merging. |
See discussion in #3097
Untested, but I think I've got the logic right, I'd normally throw more brackets at it to make sure, but I based it off the lit way quest.