Disambiguation of SECU #5368
Disambiguation of SECU #5368
Conversation
cicku
changed the base branch from
Delete-name-tag-for-charging-stations
to
main
|
You have another commit that snuck in here too |
Looks like they committed from a stale branch. This was probably a mistake as these changes were rejected in #4985 in favor of preserveTags. |
|
Yes I didn't know why that the PR was trying to merge into an abandoned branch. Just corrected it but it pulled in another one. Would you please only merge my commit later? I'm currently not able to edit from my phone. |
|
Do I have to remove the id if changing the existing entry? |
It’s not needed - next time someone runs |
|
Can this be merged now? |
Since these two entries have the same name and locationSet, they will get the same id. I'll disambiguate these locationSets sometime today. |
|
Thanks @cicku for your patience! |
|
@arch0345 Hi, may I ask how soon will I be able to use the new tag suggestion? Currently I can only see the one in NC as usual. Is a new iD release required because of duplicate "id"s? |
|
It seems to be working now? Add node, search for "secu" in Maryland:
Add node, search for "secu" in North Carolina:
iD and RapiD pull the latest compatible NSI data from a CDN, and current version is from a release a few days ago: |
Previously SECU was only for the credit union based in North Carolina, and it has been wrongly used in OSM when mapping another credit union based in Maryland.
This PR requires review before merging, to avoid further confusion.