Improve names and tags for Correios depots and post offices

[vgeorge]

This should address the issues discussed in #7100. Changes:

• Use extended names to differentiate post offices from depots
• Use brand:* instead of operator:* in post offices

cc @matheusgomesms @UKChris-osm @willemarcel

---

Fix #7100

[matheusgomesms]

Thanks a lot, @vgeorge!! It looks great to me! A couple of details:

1 - I guess we would have to delete the entry from operators folder and create another one in brands folder, for the post_office tag (someone from NSI please confirm that).

2 - It seems that post boxes are auto populated from post offices. While I see why you changed the name, to be clarified when editing, in this case, shouldn't it still be displayName=Correios? This is only the display name, and then we can add name=Correios, inside tags.

3 - If we add the name=Correios tag, then we would probably have to create an exception on amenity/post_box.json file, removing the name tag, since I guess post boxes should not have a name.

I can help you with that, if you want (and agree with my observations).

[vgeorge]

@matheusgomesms I moved the post_office entry from operators to brand folder. About the post boxes, I believe their display name should be different from the post office. I couldn't find a reference to it on Correios's website, but from this news article it seems the terminology used by the company is "Caixa de Coleta dos Correios".

[matheusgomesms]

Great! I support Caixa de Coleta dos Correios for display name on post boxes.

Not sure if you agree, but for post offices I would add the tag name=Correios as well. What do you think?

[vgeorge]

@matheusgomesms I'm inclined use the extended name "Agência dos Correios", "Centro de Distribuição dos Correios" and "Caixa de Coleta dos Correios" in the name tag, but I'm not against name=Correios. Maybe we leave this change out to discuss it further with the local community?

I'm not sure how to add the post box entry, it would be great if someone could point out which changes should I do.

@LaoshuBaby @bhousel I've changed this PR status to draft, this is work in progress.

[bhousel]

Thanks @vgeorge and @matheusgomesms , this seems ok to me.

I'm not sure how to add the post box entry, it would be great if someone could point out which changes should I do.

The amenity=post_box items are generated automatically from these rules:
(basically they copy all the "brand" and "operator" post offices, but remove tags like "name" and "shop")

name-suggestion-index/data/operators/amenity/post_box.json

Lines 16 to 40 in 3fb8ab7

	"note": "Auto create post boxes for all brand post offices - a few exceptions",
	"templateExclude": [
	"fedex",
	"orlen",
	"upsstore"
	],
	"templateSource": "brands/amenity/post_office",
	"templateTags": {
	"amenity": "post_box",
	"name": "",
	"operator": "{source.tags.brand}",
	"operator:wikidata": "{source.tags.brand:wikidata}",
	"shop": ""
	}
	},
	{
	"note": "Auto create post boxes for all operator post offices except Swiss Post",
	"templateExclude": ["diepost"],
	"templateSource": "operators/amenity/post_office",
	"templateTags": {
	"amenity": "post_box",
	"name": "",
	"shop": ""
	}
	},