Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow the locale of the login page to be set #130

Merged
merged 1 commit into from
Apr 26, 2024
Merged

allow the locale of the login page to be set #130

merged 1 commit into from
Apr 26, 2024

Conversation

k-yle
Copy link
Contributor

@k-yle k-yle commented Feb 22, 2024

Closes #23

This PR allows you to specify the language of the login page. This unblocks #3595

@k-yle k-yle mentioned this pull request Feb 22, 2024
Merged
@bhousel
Copy link
Member

bhousel commented Apr 26, 2024

Thanks @k-yle 👍
Sorry I missed this!

@bhousel bhousel merged commit a597d52 into osmlab:main Apr 26, 2024
@bhousel
Copy link
Member

bhousel commented Apr 26, 2024

Hey @k-yle I tried this out today, but I found that passing a param like locale=de to the login page doesn't seem to change the local of the page. Maybe I'm missing something?

@k-yle
Copy link
Contributor Author

k-yle commented Apr 26, 2024

@bhousel It works for me, I use chrome with navigator.languages set to ['mi', 'en-NZ']. Here are some screenshots:

https://osm.org/login?locale=de https://osm.org/login?locale=es-CO https://osm.org/login?locale=zh-Hans (invalid)
image image image

@k-yle k-yle deleted the locale branch April 26, 2024 23:34
@bhousel
Copy link
Member

bhousel commented Apr 27, 2024 •
edited
Loading

Cool! I didn't know that it would do that.

It looks like what I'm seeing is that I'm redirected from /authorize to /login with a referer, and it doesn't preserve the locale param. Is this maybe an issue with osm website?

Screenshot 2024-04-27 at 8 59 30 AM

After supplying my credentials it does return me back to the authorize page and it's properly localized:
Screenshot 2024-04-27 at 9 07 41 AM

bhousel added a commit to facebook/Rapid that referenced this pull request Apr 27, 2024
@bhousel
Try to include locale code in login/logout pages
a3767e0 
re: #1389
re: osmlab/osm-auth#130
re: openstreetmap/iD#10121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Localization
2 participants
@k-yle @bhousel