Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue - pull in changes from iD for v2.3.0 #1389

Closed
12 tasks done
bhousel opened this issue Apr 26, 2024 · 0 comments
Closed
12 tasks done

Tracking issue - pull in changes from iD for v2.3.0 #1389

bhousel opened this issue Apr 26, 2024 · 0 comments
Assignees
Milestone

Comments

@bhousel
Copy link
Contributor

bhousel commented Apr 26, 2024

This is just a placeholder issue for the work I'm pulling in from elsewhere.
We will include these fixes in the next Rapid release.

@bhousel bhousel added this to the v2.3 milestone Apr 26, 2024
@bhousel bhousel self-assigned this Apr 26, 2024
bhousel added a commit that referenced this issue Apr 29, 2024
re: #1389
re: openstreetmap/iD#10089
re: openstreetmap/iD#9502
re: openstreetmap/iD#9788

This was tricky to track down, as iD#10089 doesn't actually fix the issue
properly - really we should just not be using utilArrayIdentical with objects.

I wrote some tests to actually cover this issue and ensure that's it is fixed
correctly by comparing relation IDs.
bhousel added a commit that referenced this issue Apr 29, 2024
@bhousel bhousel closed this as completed in 70620fc May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant