Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IoM, Jersey, and Guernsey #334

Closed
wants to merge 1 commit into from
Closed

IoM, Jersey, and Guernsey #334

wants to merge 1 commit into from

Conversation

jnicho02
Copy link
Contributor

@jnicho02 jnicho02 commented Feb 8, 2020

Should be a simple country code expansion...but doesn't appear to be taking effect. See #333

@bhousel
Copy link
Member

bhousel commented Feb 8, 2020

Hmm it looks more like I'm probably using Country Coder wrong.

This is what I get when I ask it directly using aggregateFeature, which returns all of the members as a MultiPolygon:

let cc = require('@ideditor/country-coder');
let f = cc.aggregateFeature('gb');
JSON.stringify(f);

Screenshot 2020-02-08 12 18 30

So I'm going to dig into what location-conflation is doing wrong. Turf is supposed to union all of those polygons together, but maybe it's not.

@bhousel
Copy link
Member

bhousel commented Feb 10, 2020

closing here, as the bug is upsteream - see #333

@bhousel bhousel closed this Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants