Include some spanish regions

[Crashillo]

Features and resources (telegram & wiki)

• Castile and Leon
• Madrid
• Valencian Community

It also includes a slight refactor of the spain resource names to organise them properly.

Caveats

npm run test is failing checking the features, but I cannot figure out why.

🏗   Building data...
📦  Defaults: ✓ 1
📦  Features: ✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓/home/hugo/Proyectos/osm-community-index/node_modules/@mapbox/geojson-area/index.js:8
    switch (_.type) {
              ^

TypeError: Cannot read property 'type' of undefined
    at Object.geometry (/home/hugo/Proyectos/osm-community-index/node_modules/@mapbox/geojson-area/index.js:8:15)
    at file:///home/hugo/Proyectos/osm-community-index/scripts/build_index.js:128:28
    at Array.forEach (<anonymous>)
    at collectFeatures (file:///home/hugo/Proyectos/osm-community-index/scripts/build_index.js:102:49)
    at buildAll (file:///home/hugo/Proyectos/osm-community-index/scripts/build_index.js:54:15)
    at file:///home/hugo/Proyectos/osm-community-index/scripts/build_index.js:39:1
    at ModuleJob.run (internal/modules/esm/module_job.js:152:23)
    at async Loader.import (internal/modules/esm/loader.js:177:24)
    at async Object.loadESM (internal/process/esm_loader.js:68:5)

[bhousel]

npm run test is failing checking the features, but I cannot figure out why.

It looks like the new geojsons files are not formed properly..

[Crashillo]

Hummmm, that's odd. You may take a look at the files, even github displays them properly:

https://github.com/osmlab/osm-community-index/blob/101f329262f187753de884d885a05717a0d2d2ac/features/europe/spain/castilla-y-leon.geojson
https://github.com/osmlab/osm-community-index/blob/101f329262f187753de884d885a05717a0d2d2ac/features/europe/spain/comunitat-valenciana.geojson
https://github.com/osmlab/osm-community-index/blob/101f329262f187753de884d885a05717a0d2d2ac/features/europe/spain/madrid.geojson

What am I missing?

[Crashillo]

Oh, I see. GeometryCollection is not supported. Gotcha

[Crashillo]

I still unable to pass the tests :( As you may see the files are features now, but I'm facing two different errors:

For node 14.x the same I pasted in the OP, and for node 16.x:

> osm-community-index@5.1.5 build:index
> node scripts/build_index.js

node:internal/errors:464
    ErrorCaptureStackTrace(err);
    ^

TypeError [ERR_IMPORT_ASSERTION_TYPE_MISSING]: Module "file:///Users/hugo/populate/osm-community-index/schema/geojson.json" needs an import assertion of type "json"
    at new NodeError (node:internal/errors:371:5)
    at validateAssertions (node:internal/modules/esm/assert:82:15)
    at defaultLoad (node:internal/modules/esm/load:24:3)
    at ESMLoader.load (node:internal/modules/esm/loader:359:26)
    at ESMLoader.moduleProvider (node:internal/modules/esm/loader:280:58)
    at new ModuleJob (node:internal/modules/esm/module_job:66:26)
    at ESMLoader.#createModuleJob (node:internal/modules/esm/loader:297:17)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:261:34)
    at async ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:81:21)
    at async Promise.all (index 18) {
  code: 'ERR_IMPORT_ASSERTION_TYPE_MISSING'
}
ERROR: "build:index" exited with 1.
ERROR: "build" exited with 1.

[bhousel]

code: 'ERR_IMPORT_ASSERTION_TYPE_MISSING'

ohh yeah if you are seeing errors about import assertions, you're probably using node 17.. Can you try again with node 16?

[Crashillo]

That test was using v16.14.0

[Crashillo]

From v16.13 downwards, I get the same OP error

[bhousel]

From v16.13 downwards, I get the same OP error

Ok thanks for letting me know.. That's really disappointing that node did this 😠

I'll have to see if there is a way to import .json files that works across all the LTS versions.

[bhousel]

I ended up just adding the assert {type: 'json'}; to everywhere that we import json and raising the minimum version of node for the project. Thanks for the PR and letting me know about the issue with node!

[bhousel]

FYI I'm going to redraw the geojsons, since they are really too detailed for this project..

[Crashillo]

I'm noticing missing translations on iD, why is that? I just copy another resource files

[bhousel]

I'm noticing missing translations on iD, why is that? I just copy another resource files

I don't know.. another bug in iD I guess 🤷