Sign mode eip191 #20
Sign mode eip191 #20
Conversation
|
We should consider converting this to use YAML instead of JSON. As long as there's a deterministic mapping from json to yaml Maybe using something like this: https://github.com/ghodss/yaml |
|
TODO Here: Prettify the JSON in GetSignBytes / w/e its called. |
|
Decided to do prettified JSON instead of YAML |
| return []signingtypes.SignMode{signingtypes.SignMode_SIGN_MODE_EIP191_LEGACY_JSON} | ||
| } | ||
|
|
||
| func (s signModeEIP191LegacyJSONHandler) GetSignBytes(mode signingtypes.SignMode, data signing.SignerData, tx sdk.Tx) ([]byte, error) { |
There was a problem hiding this comment.
Change this to use prettified JSON
| aminoJSONBz := legacytx.StdSignBytes( | ||
| data.ChainID, data.AccountNumber, data.Sequence, protoTx.GetTimeoutHeight(), | ||
| legacytx.StdFee{Amount: protoTx.GetFee(), Gas: protoTx.GetGas()}, | ||
| tx.GetMsgs(), protoTx.GetMemo(), |
There was a problem hiding this comment.
I think prettified JSON happens here
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hey, would love to see this upstreamed, let me know what is needed from the sdk for this |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes