perf: CacheCtx speedups #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked state compatability on 2 days of v21.x (until upgrade height), I encourage merging |
ValarDragon
commented
Feb 5, 2024
store/cachekv/store.go
Outdated
Comment on lines
106
to
108
| if len(store.cache) == 0 && len(store.unsortedCache) == 0 { | ||
| store.sortedCache = internal.NewBTree() | ||
| store.resetSortedCache() | ||
| return |
There was a problem hiding this comment.
Actually we should really just make store.sortedCache nil here
czarcas7ic
approved these changes
Feb 6, 2024
czarcas7ic
added a commit
that referenced
this pull request
Feb 8, 2024
* De-dup param getting * Disable DenomOwners tracking * Fix some tests * chore(types): replace amino json encoder with stdlib * feat: config option to log gRPC queries (#503) * config option to log gRPC queries * clarify gRPC log comment * create var * remove quotes * go mod tidy * chore: fix CI (#509) * ci * lints and remove some unnecessary CI jobs * update tests go mod * more lints * remove denom owners since not implemented in osmosis * more lints * fix test values * implement nolint again * more test fixes * add back labeler as v4 * remove tabs and slash * update json to const * move file locations * push * fix seq num issue * Update tests/e2e/auth/vesting/suite.go * add back pwd * remove sonarcloud --------- Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> * Fix CI(#511) * perf: CacheCtx speedups (#504) * CacheKV speedups * Remove extra btree alloc * fix(x/feegrant)!: limit expired feegrant pruning to 200 per block (cosmos#19314) (#512) Co-authored-by: MSalopek <matija.salopek994@gmail.com> * feat: add testnetify logic (#506) * add testnetify logic * clarify explanation * handle errors * remove testnet app creator * simplify some logic * remove redundancy * lints * gci imports * add set store loader method * trigger upgrade flag * add extra comments to the CLI command * skip confirmation (#516) --------- Co-authored-by: Adam Tucker <adamleetucker@outlook.com> Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> Co-authored-by: MSalopek <matija.salopek994@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cref cosmos#18972