Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash amounts support #179

Merged
merged 15 commits into from
Dec 11, 2023
Merged

Slash amounts support #179

merged 15 commits into from
Dec 11, 2023

Conversation

maurolacy
Copy link
Collaborator

@maurolacy maurolacy commented Dec 5, 2023

Related to osmosis-labs/mesh-security-sdk#125.

Adds support for slashing based on historical evidence (double signing slashing), through slashing amounts instead of slash ratios.

There are still some limitations and there's room for improvement in the contracts side impls. Will be documented in a number of follow-up issues.

TODO:

  • Fix / adapt / extend tests.
  • Improve coverage / Add tests.

Copy link
Collaborator

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Collaborator

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs test fixes but otherwise looks good. Sorry for the earlier approval. 😂

@maurolacy
Copy link
Collaborator Author

Needs test fixes but otherwise looks good. Sorry for the earlier approval. 😂

Welcome. Yes, I'll continue working on this asap.

@codecov-commenter
Copy link

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Comparison is base (4402153) 86.71% compared to head (1080a83) 86.26%.

Files Patch % Lines
contracts/consumer/converter/src/contract.rs 1.26% 78 Missing ⚠️
contracts/consumer/virtual-staking/src/contract.rs 90.65% 2 Missing and 8 partials ⚠️
contracts/consumer/converter/src/ibc.rs 0.00% 3 Missing ⚠️
...ontracts/provider/external-staking/src/contract.rs 97.70% 1 Missing and 2 partials ⚠️
contracts/provider/external-staking/src/ibc.rs 0.00% 2 Missing ⚠️
...ontracts/consumer/virtual-staking/src/multitest.rs 0.00% 1 Missing ⚠️
packages/apis/src/converter_api.rs 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   86.71%   86.26%   -0.45%     
==========================================
  Files          81       81              
  Lines       14035    14253     +218     
  Branches    14035    14253     +218     
==========================================
+ Hits        12170    12295     +125     
- Misses       1288     1389     +101     
+ Partials      577      569       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maurolacy maurolacy merged commit f550681 into main Dec 11, 2023
4 checks passed
@maurolacy maurolacy deleted the effective-slash-ratio branch December 11, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants