-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enable build in pre-montery machines #1351
Conversation
github.com/zondax/hid v0.9.1-0.20220302062450-5552068d2266 // indirect | ||
github.com/zondax/hid v0.9.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does changing an indirect dependency not get overriden on go mod updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdym?
Agreed with conclusion of lowering library version! |
Codecov Report
@@ Coverage Diff @@
## main #1351 +/- ##
==========================================
- Coverage 19.82% 19.77% -0.05%
==========================================
Files 202 202
Lines 27685 27718 +33
==========================================
- Hits 5489 5482 -7
- Misses 21175 21215 +40
Partials 1021 1021
Continue to review full report at Codecov.
|
(cherry picked from commit c6ef107) # Conflicts: # go.sum
What is the purpose of the change
PR #1268 introduces a build failure bug on Mac OS <= 11 by the package
zondax/hid
.Although #1268 does remove unnecessary warning logs on Mac OS >12, I think ensuring successful build upon different machines is way more important, which could be done by reverting 1268(which upgrades the zondax/hid to 0.9.1) and use it as it was 0.9.0
cref: cosmos/cosmos-sdk#11364 (comment), cosmos/cosmos-sdk#11365
Brief change log
Testing and Verifying
Locally tested in both mac os >12, mac os <= 11 that #1268 fails on mac os <= 11, while it succeeds on mac OS > 12.
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? no