Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow state exporting from any directory #3608

Merged
merged 2 commits into from
Dec 4, 2022
Merged

Allow state exporting from any directory #3608

merged 2 commits into from
Dec 4, 2022

Conversation

ValarDragon
Copy link
Member

What is the purpose of the change

Fixes the bug that prevents you from state exporting outside of the .osmosisd directory.
Driveby deletes the unused "zeroForOne" export code as well.

Testing and Verifying

Tested manually

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? N/A

@ValarDragon ValarDragon added A:backport/v12.x backport patches to v12.x branch V:state/compatible/backport State machine compatible PR, should be backported A:backport/v13.x backport patches to v13.x branch labels Dec 3, 2022
@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Dec 3, 2022
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one less silly bug to worry about :)

@ValarDragon ValarDragon merged commit da4f503 into main Dec 4, 2022
@ValarDragon ValarDragon deleted the dev/fix_export branch December 4, 2022 20:05
mergify bot pushed a commit that referenced this pull request Dec 4, 2022
* Allow exporting from any directory

* Changelog

(cherry picked from commit da4f503)

# Conflicts:
#	CHANGELOG.md
#	app/export.go
mergify bot pushed a commit that referenced this pull request Dec 4, 2022
* Allow exporting from any directory

* Changelog

(cherry picked from commit da4f503)
czarcas7ic pushed a commit that referenced this pull request Dec 5, 2022
* Allow exporting from any directory

* Changelog

(cherry picked from commit da4f503)

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
ValarDragon added a commit that referenced this pull request Dec 6, 2022
* Allow state exporting from any directory (#3608)

* Allow exporting from any directory

* Changelog

(cherry picked from commit da4f503)

# Conflicts:
#	CHANGELOG.md
#	app/export.go

* Fix conflicts

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Dev Ojha <dojha@berkeley.edu>
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v12.x backport patches to v12.x branch A:backport/v13.x backport patches to v13.x branch C:app-wiring Changes to the app folder V:state/compatible/backport State machine compatible PR, should be backported
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants