Added rate limits in upgrade #4340

nicolaslara · 2023-02-16T09:09:41Z

Closes: #4303

What is the purpose of the change

This adds the rate limits in the v15 upgrade for when https://www.mintscan.io/osmosis/proposals/427 passes.

Brief Changelog

Add rate limits in v15

Testing and Verifying

The upgrade has tests.
The upgrade has E2E tests
This should also be tested on a testnet with state export.

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

ValarDragon · 2023-02-17T14:49:55Z

RIP goimports error. Do you have your editor set to format on save?

nicolaslara · 2023-02-17T15:51:31Z

RIP goimports error. Do you have your editor set to format on save?

I do, but it doesn't work when I fix conflicts and some other weird situations like that.

@ValarDragon but!! this is not ready. The E2E tests are passing because I deactivated them after failing to get them to work (rip).

I asked Nicco to test the upgrade with a state export to make sure the issue is with E2E and not with the upgrade

nicolaslara · 2023-02-18T10:12:17Z

That change makes a lot of sense! I thought that was just initialization. Thanks for the find!

nicolaslara · 2023-02-19T15:07:39Z

hmm, this is still failing when there contracts exist on v14. I'll try to test this again tomorrow on a real node and see what happens

* param space initialization for rate limiting * lint

p0mvn · 2023-02-22T02:18:14Z

Latest updates:

wired ibc-rate-limit as SDK module to have init and export genesis logic
changed querier to be code-gen compatible and fixed CLI
fixed bug with not getting params correctly due to not having a pointer receiver on ParamSetPairs:

osmosis/x/ibc-rate-limit/types/params.go

Line 44 in af89301

func (p *Params) ParamSetPairs() paramtypes.ParamSetPairs {
fixed bug with overriding contract parameter due to ibc-rate-limit consensus version being set to 1, leading to overwrite during the upgrade. Fixed with:

osmosis/app/upgrades/v15/upgrades.go

Line 56 in af89301

fromVM[ibcratelimittypes.ModuleName] = 0

We manually checked the presence of the contract parameter and rate limits post-upgrade. However, we should add a test in e2e_test.go doing that for us. I think this is the only remaining TODO here

tests/e2e/configurer/chain/chain.go

tests/e2e/e2e_test.go

This reverts commit ab5cf6c.

tests/e2e/e2e_test.go

p0mvn

LGTM

* added rate limits in upgrade * added upgrade test * refactor rate limiting tests and added rate limits pre-upgrade * lint * goimports * experiments for E2E * post merge lints * added RL before upgrade * just get the latest contract * experiments * updated wasm file * remove unnecessary prints * bad check * experiments without e2e * removed unnecessary fmt * param space initialization for rate limiting (#4360) * param space initialization for rate limiting * lint * better test * properly initialize empty params * fix typo * adding RL to E2E * removing RL again from E2E * debug * genesis * genesis 2 * add genesis and solve params bug * uncomment setup rate limiting * added configurable gov module * clean up * clean up and genesis test * upgrade handler * genesis clean up * clean up e2e * wire querier * route fix * fix router * debug things * fix init genesis bug * push fix * lint * fix * clean up upgrades * testing propper params after upgrade in E2E * "properly" unmarshaling the parm * goimports * allowing for types other than objects in cosmwasm queries * fix check for param reset * remove unnecessary prints * compiled with the proper vesion of workspace optimizer * Revert "compiled with the proper vesion of workspace optimizer" This reverts commit ab5cf6c. * added length check * params experiment for test with state-export --------- Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: Roman <ackhtariev@gmail.com> (cherry picked from commit a1e2b3d) # Conflicts: # app/keepers/modules.go # app/modules.go # app/upgrades/v15/export_test.go # app/upgrades/v15/upgrade_test.go # app/upgrades/v15/upgrades.go # tests/e2e/configurer/chain/commands.go # tests/e2e/e2e_test.go

* added rate limits in upgrade * added upgrade test * refactor rate limiting tests and added rate limits pre-upgrade * lint * goimports * experiments for E2E * post merge lints * added RL before upgrade * just get the latest contract * experiments * updated wasm file * remove unnecessary prints * bad check * experiments without e2e * removed unnecessary fmt * param space initialization for rate limiting (#4360) * param space initialization for rate limiting * lint * better test * properly initialize empty params * fix typo * adding RL to E2E * removing RL again from E2E * debug * genesis * genesis 2 * add genesis and solve params bug * uncomment setup rate limiting * added configurable gov module * clean up * clean up and genesis test * upgrade handler * genesis clean up * clean up e2e * wire querier * route fix * fix router * debug things * fix init genesis bug * push fix * lint * fix * clean up upgrades * testing propper params after upgrade in E2E * "properly" unmarshaling the parm * goimports * allowing for types other than objects in cosmwasm queries * fix check for param reset * remove unnecessary prints * compiled with the proper vesion of workspace optimizer * Revert "compiled with the proper vesion of workspace optimizer" This reverts commit ab5cf6c. * added length check * params experiment for test with state-export --------- Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: Roman <ackhtariev@gmail.com> (cherry picked from commit a1e2b3d) # Conflicts: # app/modules.go # tests/e2e/e2e_test.go

* Added rate limits in upgrade (#4340) * added rate limits in upgrade * added upgrade test * refactor rate limiting tests and added rate limits pre-upgrade * lint * goimports * experiments for E2E * post merge lints * added RL before upgrade * just get the latest contract * experiments * updated wasm file * remove unnecessary prints * bad check * experiments without e2e * removed unnecessary fmt * param space initialization for rate limiting (#4360) * param space initialization for rate limiting * lint * better test * properly initialize empty params * fix typo * adding RL to E2E * removing RL again from E2E * debug * genesis * genesis 2 * add genesis and solve params bug * uncomment setup rate limiting * added configurable gov module * clean up * clean up and genesis test * upgrade handler * genesis clean up * clean up e2e * wire querier * route fix * fix router * debug things * fix init genesis bug * push fix * lint * fix * clean up upgrades * testing propper params after upgrade in E2E * "properly" unmarshaling the parm * goimports * allowing for types other than objects in cosmwasm queries * fix check for param reset * remove unnecessary prints * compiled with the proper vesion of workspace optimizer * Revert "compiled with the proper vesion of workspace optimizer" This reverts commit ab5cf6c. * added length check * params experiment for test with state-export --------- Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: Roman <ackhtariev@gmail.com> (cherry picked from commit a1e2b3d) # Conflicts: # app/modules.go # tests/e2e/e2e_test.go * fix conflicts --------- Co-authored-by: Nicolas Lara <nicolaslara@gmail.com>

github-actions bot added the C:app-wiring Changes to the app folder label Feb 16, 2023

nicolaslara self-assigned this Feb 16, 2023

nicolaslara added the V:state/compatible/backport State machine compatible PR, should be backported label Feb 16, 2023

ValarDragon added V:state/breaking State machine breaking PR A:backport/v15.x backport patches to v15.x branch and removed V:state/compatible/backport State machine compatible PR, should be backported labels Feb 17, 2023

nicolaslara and others added 20 commits February 20, 2023 17:16

added rate limits in upgrade

391f760

added upgrade test

ea02c96

refactor rate limiting tests and added rate limits pre-upgrade

5c50584

lint

c25b561

goimports

04b9659

experiments for E2E

ee0c581

post merge lints

63b7e8c

added RL before upgrade

4cda3ec

just get the latest contract

0d80f36

experiments

acf9bc2

updated wasm file

318de89

remove unnecessary prints

e8d5c31

bad check

d5385ff

experiments without e2e

56de8d0

removed unnecessary fmt

b9af8f0

param space initialization for rate limiting (#4360)

61e48ea

* param space initialization for rate limiting * lint

better test

de3a888

properly initialize empty params

971ba4a

fix typo

1663316

adding RL to E2E

d6d2ab8

nicolaslara commented Feb 22, 2023

View reviewed changes

tests/e2e/configurer/chain/chain.go Show resolved Hide resolved

nicolaslara added 6 commits February 22, 2023 10:56

testing propper params after upgrade in E2E

c78d38e

"properly" unmarshaling the parm

eb85cb2

goimports

f2e42c0

allowing for types other than objects in cosmwasm queries

3722f1a

fix check for param reset

2490cf9

remove unnecessary prints

376fccd

nicolaslara marked this pull request as ready for review February 22, 2023 12:33

p0mvn reviewed Feb 22, 2023

View reviewed changes

tests/e2e/e2e_test.go Outdated Show resolved Hide resolved

nicolaslara added 3 commits February 22, 2023 15:39

compiled with the proper vesion of workspace optimizer

ab5cf6c

Revert "compiled with the proper vesion of workspace optimizer"

fd692be

This reverts commit ab5cf6c.

added length check

909a3a8

p0mvn reviewed Feb 22, 2023

View reviewed changes

tests/e2e/e2e_test.go Show resolved Hide resolved

p0mvn approved these changes Feb 22, 2023

View reviewed changes

params experiment for test with state-export

d3781d3

nicolaslara added A:backport/v14.x backport patches to v14.x branch and removed A:backport/v14.x backport patches to v14.x branch labels Feb 23, 2023

nicolaslara merged commit a1e2b3d into main Feb 23, 2023

nicolaslara deleted the nicolas/set-rate-limits branch February 23, 2023 12:42

This was referenced Feb 23, 2023

Added rate limits in upgrade (backport #4340) #4404

Closed

Added rate limits in upgrade (backport #4340) #4405

Merged

This was referenced Feb 23, 2023

Backport RL genesis #4406

Closed

backport genesis for RL #4408

Merged

github-actions bot mentioned this pull request Apr 1, 2024

Broken Links Detected #7903

Closed

github-actions bot mentioned this pull request May 15, 2024

Broken Links Detected #8269

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added rate limits in upgrade #4340

Added rate limits in upgrade #4340

nicolaslara commented Feb 16, 2023 •

edited

ValarDragon commented Feb 17, 2023

nicolaslara commented Feb 17, 2023

nicolaslara commented Feb 18, 2023

nicolaslara commented Feb 19, 2023

p0mvn commented Feb 22, 2023

p0mvn left a comment

Added rate limits in upgrade #4340

Added rate limits in upgrade #4340

Conversation

nicolaslara commented Feb 16, 2023 • edited

What is the purpose of the change

Brief Changelog

Testing and Verifying

Documentation and Release Note

ValarDragon commented Feb 17, 2023

nicolaslara commented Feb 17, 2023

nicolaslara commented Feb 18, 2023

nicolaslara commented Feb 19, 2023

p0mvn commented Feb 22, 2023

p0mvn left a comment

Choose a reason for hiding this comment

nicolaslara commented Feb 16, 2023 •

edited