migrate stXXX/XXX constant product pool -> stableswap pool #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
asalzmann
commented
Feb 22, 2023
p0mvn
requested review from
stackman27,
AlpinYukseloglu,
mattverse and
nicolaslara
mattverse
reviewed
Feb 22, 2023
asalzmann
commented
Feb 22, 2023
p0mvn
reviewed
Feb 22, 2023
p0mvn
reviewed
Feb 22, 2023
p0mvn
reviewed
Feb 22, 2023
asalzmann
commented
Feb 22, 2023
|
Please merge This is the final step needed for e2e testing the migrations during the upgrade. We created Stride balancer pools via genesis in v14 in #4393 Now, when the upgrade runs, the pools will be found and the newly implemented migration run against them |
mattverse
approved these changes
Feb 23, 2023
…sis into aidan/migrate-pools-v15
p0mvn
reviewed
Feb 23, 2023
p0mvn
reviewed
Feb 23, 2023
app/upgrades/v15/upgrade_test.go
Outdated
| // join the pool | ||
| shareOutAmount := sdk.NewInt(10000000) | ||
| tokenInMaxs := sdk.NewCoins(sdk.NewCoin("foo", sdk.NewInt(5000000)), sdk.NewCoin("bar", sdk.NewInt(5000000))) | ||
| _, _, err = suite.App.GAMMKeeper.JoinPoolNoSwap(suite.Ctx, testAccount, poolID, shareOutAmount, tokenInMaxs) |
There was a problem hiding this comment.
So this function has sharesOut as one of its returns, we could use these to then use for ExitPool
There was a problem hiding this comment.
Nice, used this below
p0mvn
reviewed
Feb 23, 2023
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2023
* migrate stXXX/XXX constant product pool -> stableswap pool * update upgrade unittest * send LP tokens to lpWallet * update tests * add join, exit unittest * add checks per comments * one more comment * lp pre-upgrade * clean up and TODOs * fix e2e * add query * rm TestMigrateBalancerToStable, update ExitPool in upgrade_test.go * rm TestMigrateBalancerToStable * update changelog * fix e2e * more assertions for TestMigrateBalancerToStablePools * lint --------- Co-authored-by: Roman <roman@osmosis.team> (cherry picked from commit 0355d27) # Conflicts: # tests/e2e/configurer/chain/queries.go
p0mvn
added a commit
that referenced
this pull request
Feb 23, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Migrate pools 833, 817, and 810 from constant product -> stable swap.
Brief Changelog
Testing and Verifying
This change added tests and can be verified as follows:
TestMigrateBalancerToStablePoolsto verify liquidity stays constant before/after the migrationCreatePreUpgradeStateby LPing to the 3 poolsTestMigrateBalancerToStablee2e test which swaps in and exits each poolDocumentation and Release Note
Unreleasedsection inCHANGELOG.md? yesCHANGELOG.md