Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL] Delete more test code #5322

Merged
merged 5 commits into from
May 26, 2023
Merged

[CL] Delete more test code #5322

merged 5 commits into from
May 26, 2023

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented May 26, 2023 •
edited
Loading

What is the purpose of the change

Helps get more attention on relevant parts of test that matters. (In this process, noticed some tests that weren't doing anything)

Testing and Verifying

  • bench_test: Removes some repeated code
  • incentives_test: Make a helper for setupBalancerPoolWithFractionLocked
  • incentives_test: Remove Err and ErrorIs / ErrorContains duplicate checks. just do the more specific check
  • incentives_test: TestPrepareBalancerPoolAsFullRange split out moving pool error tests

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@mattverse mattverse added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog labels May 26, 2023
czarcas7ic
czarcas7ic approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

@czarcas7ic czarcas7ic merged commit cdeeee5 into main May 26, 2023
@czarcas7ic czarcas7ic deleted the dev/delete_more_test_code branch May 26, 2023 18:53
pysel pushed a commit that referenced this pull request Jun 6, 2023
@ValarDragon @pysel
[CL] Delete more test code (#5322)
68db04e 
* Delete more test code

* De-dup some benchmark code

* Split out error case testing from main test body

* dedup balancer setup code

* More moving of code to common functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@p0mvn p0mvn Awaiting requested review from p0mvn p0mvn is a code owner

Assignees
No one assigned
Labels
A:no-changelog C:x/concentrated-liquidity V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValarDragon @czarcas7ic @mattverse