refactor: reduce the number of returns in tick conversions and update position #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
V:state/compatible/backport
github-actions
bot
added
C:x/superfluid
C:simulator
p0mvn
requested review from
mattverse,
stackman27,
AlpinYukseloglu and
czarcas7ic
as code owners
mergify bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
… position (#6071) * refactor: reduce the number of returns in tick conversions and update position * changelog (cherry picked from commit b3cbdd4) # Conflicts: # CHANGELOG.md # x/concentrated-liquidity/lp.go # x/concentrated-liquidity/lp_test.go # x/concentrated-liquidity/position.go # x/superfluid/keeper/slash.go # x/superfluid/types/expected_keepers.go
traviolus
pushed a commit
to alleslabs/osmosis
that referenced
this pull request
Aug 23, 2023
… position (osmosis-labs#6071) (osmosis-labs#6087) * refactor: reduce the number of returns in tick conversions and update position * changelog (cherry picked from commit b3cbdd4) Co-authored-by: Roman <roman@osmosis.team>
p0mvn
added a commit
that referenced
this pull request
Aug 29, 2023
… position (#6071) * refactor: reduce the number of returns in tick conversions and update position * changelog
nicolaslara
pushed a commit
that referenced
this pull request
Aug 31, 2023
… position (#6071) * refactor: reduce the number of returns in tick conversions and update position * changelog
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards: #5984
What is the purpose of the change
This PR continue removing too many returns to later enable a revive linter.
This PR:
UpdatePositionTicksToSqrtPricefunctionTesting and Verifying
This change is already covered by existing tests
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)