refactor(poolmanager): GetPoolDenoms method on PoolI for SQS #6863
Conversation
p0mvn
added
V:state/compatible/backport
p0mvn
requested review from
czarcas7ic,
mattverse and
AlpinYukseloglu
as code owners
|
@Mergifyio refresh |
github-actions
bot
added
C:x/gamm
✅ Pull request refreshed |
x/poolmanager/types/pool.go
Outdated
| @@ -2,7 +2,7 @@ package types | |||
|
|
|||
| import ( | |||
| sdk "github.com/cosmos/cosmos-sdk/types" | |||
| proto "github.com/cosmos/gogoproto/proto" | |||
| proto "github.com/gogo/protobuf/proto" | |||
There was a problem hiding this comment.
Just curious, what's the reason we're changing this from cosmos' gogo proto to the original one?
There was a problem hiding this comment.
Correct, we need to switch this back, good catch (was likely merge conflict)
|
Mentioning here that I had issues with this method for cwpools on mainet |
What was the solution to the issue? |
|
@p0mvn I just changed the GetPools method on the cwpool side to return the keeper as well. It's in my draft PR for implementing the route query |
OK, thanks for getting back. I will then merge this, and let you fix the issue in your PR. |
|
OK tests added |
* refactor(poolmanager): GetPoolDenoms method on PoolI for SQS * changelog * mocks * change proto dep * transmuter pool * cfmm test * CL test (cherry picked from commit 4c54425) # Conflicts: # CHANGELOG.md
…#6863) (#6902) * refactor(poolmanager): GetPoolDenoms method on PoolI for SQS (#6863) * refactor(poolmanager): GetPoolDenoms method on PoolI for SQS * changelog * mocks * change proto dep * transmuter pool * cfmm test * CL test (cherry picked from commit 4c54425) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Roman <roman@osmosis.team>
Closes: #XXX
What is the purpose of the change
Add GetPoolDenoms on PoolI interface in the poolmanager. Provide implementations for each pool.
This is useful for SQS.