Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State Sync #707

Merged
merged 3 commits into from
Jan 4, 2022
Merged

State Sync #707

merged 3 commits into from
Jan 4, 2022

Conversation

faddat
Copy link
Member

@faddat faddat commented Jan 3, 2022

Description

This makes state sync work correctly, in a single go.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@ValarDragon
Copy link
Member

Woah, thanks for showing how this is done!

cc @UnityChaos @czarcas7ic @daniel-farina for context!

If this is state compatible, can we make a tendermint version on v0.34.x that just does this if the app version is nil, within the start command?

@codecov-commenter
Copy link

Codecov Report

Merging #707 (1f6a6e9) into main (aded876) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #707   +/-   ##
=======================================
  Coverage   18.69%   18.69%           
=======================================
  Files         171      171           
  Lines       23814    23814           
=======================================
  Hits         4452     4452           
  Misses      18600    18600           
  Partials      762      762           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aded876...1f6a6e9. Read the comment docs.

@daniel-farina daniel-farina merged commit cf991ff into main Jan 4, 2022
@daniel-farina daniel-farina deleted the faddat/statesync branch January 4, 2022 03:48
ValarDragon pushed a commit that referenced this pull request Jan 9, 2022
* Update statesync.sh

* Update statesync.sh

* Update statesync.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants