Remove iterator calls in two CL operations #7499
Conversation
This removes one unneeded iterator call in CL CreatePosition It removes two unneeded iterator calls in CL addToPosition This appears to be an approximately 10% speedup to both operations. (.2% impact to state machine processing time)
ValarDragon
requested review from
czarcas7ic,
p0mvn and
AlpinYukseloglu
as code owners
| // Note that here we currently use the iterator based definition to search | ||
| // for a remaining position in the pool. Since we have removed a position we need to | ||
| // search if there are more. | ||
| // Ideally in the future we could have a simple "num positions" counter to make this logic |
There was a problem hiding this comment.
Do you mean adding a state entry for num positions where key is address and value is num positions?
There was a problem hiding this comment.
Yes! But key is poolID
There was a problem hiding this comment.
ah right pool id. Would the speedup of using num counter be worthy for making an github issue and coming back to it to address it?
There was a problem hiding this comment.
I think so, but there are other higher priorities in the CL performance line of work.
| pool, err := k.GetConcentratedPoolById(ctx, position.PoolId) | ||
| if err != nil { | ||
| return 0, osmomath.Int{}, osmomath.Int{}, err | ||
| } | ||
|
|
||
| anyPositionsRemainingInPool := k.PoolHasPosition(ctx, pool) |
There was a problem hiding this comment.
Does this also give us speed up compared to calling HasAnyPositionForPool directly?
There was a problem hiding this comment.
Yes! HasAnyPositionForPool runs an iterator. PoolHasPosition just checks data off the pool struct directly
There was a problem hiding this comment.
If so, isn't it also possible to change HasAnyPositionForPool to do GetConcentratedPoolById then call PoolHasPosition instead of running an iterator?
There was a problem hiding this comment.
yeah, it was mostly that we still need the old method as well for withdraw position.
Maybe we rename this
This removes one unneeded iterator call in CL CreatePosition It removes two unneeded iterator calls in CL addToPosition
This appears to be an approximately 10% speedup to both operations. (.2% impact to state machine processing time)
This is the same idea as #7258 and should be covered by existing tests. I left a code comment for why we can't do this same idea to WithdrawPosition.