feat: tick init/deinit for CL #7622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
commented
Feb 27, 2024
p0mvn
commented
Feb 27, 2024
p0mvn
added
V:state/compatible/backport
p0mvn
commented
Feb 27, 2024
AlpinYukseloglu
approved these changes
Feb 27, 2024
x/concentrated-liquidity/tick.go
Outdated
| // set the tick's spread reward growth opposite direction of last traversal to the spread factor accumulator's value | ||
| if liquidityBefore.IsZero() { | ||
| if tickIndex <= currentTick { | ||
| accum, err := k.GetSpreadRewardAccumulator(ctx, poolId) |
There was a problem hiding this comment.
Removing these reads should change the gas for this function so this is not state compatible right? Since even if this branch didn't do anything the reads were still happening
There was a problem hiding this comment.
Right. I will separate it into a separate PR
p0mvn
force-pushed
the
roman/cl-tick-events
branch
from
446f987
to
082f101
Compare
|
Will backport and sync a v23.x node |
mergify bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
(cherry picked from commit ea2310a) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
(cherry picked from commit ea2310a)
p0mvn
added a commit
that referenced
this pull request
Feb 28, 2024
czarcas7ic
added a commit
that referenced
this pull request
Feb 29, 2024
czarcas7ic
added a commit
that referenced
this pull request
Feb 29, 2024
This was referenced Mar 12, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Adding events for initializing and deinitializing ticks. This is needed by Numia for computing the APRs.
As a drive-by change, I noticed that we recomputed the spread rewards accumulators and removed the duplicate logic.
Testing and Verifying
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)