feat: whitelist addresses param for setting fee tokens #7855
Conversation
github-actions
bot
added
C:CLI
C:x/txfees
C:app-wiring
czarcas7ic
added
V:state/breaking
| ### CometBFT | ||
|
|
||
| * [#5](https://github.com/osmosis-labs/cometbft/pull/5) Batch verification | ||
| * [#11](https://github.com/osmosis-labs/cometbft/pull/11) Skip verification of commit sigs | ||
| * [#13](https://github.com/osmosis-labs/cometbft/pull/13) Avoid double-saving ABCI responses | ||
| * [#20](https://github.com/osmosis-labs/cometbft/pull/20) Fix the rollback command | ||
|
|
There was a problem hiding this comment.
Added the update in a separate PR.
czarcas7ic
changed the title
czarcas7ic
requested review from
nicolaslara,
p0mvn and
AlpinYukseloglu
as code owners
WalkthroughThe Osmosis project introduced a feature for whitelisting addresses for setting fee tokens, enhancing control over transaction fees. This update involves modifications across various components, including keeper functions, upgrade handling, and protobuf definitions, to support the new whitelisting functionality and parameter management. Additionally, CometBFT received improvements in verification processes and command handling, contributing to overall system efficiency and reliability. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
* whitelist address for setting fee tokens * register subspace and codec * changelog * add params to genesis, add test case for SenderValidationSetFeeTokens * add genesis test and TestMsgSetFeeTokens * add DAO address to upgrade handler * use osmoutils helper (cherry picked from commit f3e311a)
* whitelist address for setting fee tokens * register subspace and codec * changelog * add params to genesis, add test case for SenderValidationSetFeeTokens * add genesis test and TestMsgSetFeeTokens * add DAO address to upgrade handler * use osmoutils helper (cherry picked from commit f3e311a) Co-authored-by: Adam Tucker <adam@osmosis.team>
Closes: #XXX
What is the purpose of the change
Having the capability to designate a new token as a whitelisted fee token on the same day it becomes active on Osmosis is strategically important. Currently, we must wait a week for a governance process to include this token in the whitelist. To address this, we propose introducing a new parameter. This parameter would function similarly to the existing taker fee whitelist parameter, enabling a selected list of specific addresses the authority to modify the list of whitelisted fee tokens.
Testing and Verifying
Added respective gotests to newly added methods.
Summary by CodeRabbit
Paramsmessage in thetxfeesmodule to hold parameters including whitelisted fee token setters.