Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: default TimeoutCommit to 2s #7912

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Apr 2, 2024

Closes: #7907

What is the purpose of the change

Moves default from 3s to 2s, targeting 3 second blocks.

Summary by CodeRabbit

  • New Features
    • Adjusted the default block time to enhance speed and efficiency in transactions.

@czarcas7ic czarcas7ic added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v24.x backport patches to v24.x branch labels Apr 2, 2024
@czarcas7ic czarcas7ic marked this pull request as ready for review April 2, 2024 04:13
Copy link
Contributor

coderabbitai bot commented Apr 2, 2024

Walkthrough

The recent changes to the codebase involve adjusting the TimeoutCommit configuration from 3 seconds to 2 seconds. This modification is aimed at achieving faster block times, aligning with the project's goal to reduce block times in its version updates. The adjustments were made across two main files within the command options of the Osmosis daemon (osmosisd), ensuring the new default setting is applied consistently across the system.

Changes

Files Change Summary
cmd/osmosisd/cmd/init.go TimeoutCommit changed from 3s to 2s
cmd/osmosisd/cmd/root.go TimeoutCommit in tmcConfig & serverCtx.Config changed from 3s to 2s

Assessment against linked issues

Objective Addressed Explanation
Default timeout to 2s (#7907)
Auto override to 2s unless flag provided (#7907) The changelog and code snippets do not explicitly mention the implementation of an auto override mechanism or the use of a flag to control this behavior.

Poem

In the realm of code, where time is gold,
A rabbit hopped, bold and bold.
"From three to two," it said with glee,
"Faster blocks, as quick as can be!"
🚀🐇💨
With every hop, the code did change,
In Osmosis lands, it rearranged.
"Celebrate," it cheered, "for we are free,
To sync our dreams, more swiftly we'll see!"

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@ValarDragon ValarDragon merged commit abbc0a5 into main Apr 2, 2024
1 check passed
@ValarDragon ValarDragon deleted the adam/timeout-commit-to-2s branch April 2, 2024 04:34
mergify bot pushed a commit that referenced this pull request Apr 2, 2024
* timeout commit to 2s

* changelog

(cherry picked from commit abbc0a5)
ValarDragon pushed a commit that referenced this pull request Apr 2, 2024
* timeout commit to 2s

* changelog

(cherry picked from commit abbc0a5)

Co-authored-by: Adam Tucker <adam@osmosis.team>
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v24.x backport patches to v24.x branch V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default timeout to 2s
2 participants