Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: default timeout commit to 1.5s #8149

Merged
merged 2 commits into from
Apr 26, 2024
Merged

chore: default timeout commit to 1.5s #8149

merged 2 commits into from
Apr 26, 2024

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Apr 26, 2024

Closes: #XXX

What is the purpose of the change

Moves default from 2s to 1.5s, targeting 2.5 second blocks.

Summary by CodeRabbit

  • New Features

    • Introduced a query for retrieving individual authenticators.
    • Implemented a stargate whitelist for enhanced query management.
  • Bug Fixes

    • Adjusted the default timeout for commit operations from 2 seconds to 1.5 seconds to improve system responsiveness.

@czarcas7ic czarcas7ic added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v24.x backport patches to v24.x branch labels Apr 26, 2024
@czarcas7ic czarcas7ic marked this pull request as ready for review April 26, 2024 20:23
Copy link
Contributor

coderabbitai bot commented Apr 26, 2024

Walkthrough

Version v24.0.4 introduces a new query for retrieving single authenticators and adds a stargate whitelist. Additionally, the default timeoutCommit in the consensus configuration is reduced from 2 seconds to 1.5 seconds, enhancing the system's responsiveness.

Changes

File Path Change Summary
cmd/osmosisd/cmd/init.go TimeoutCommit changed from 2 seconds to 1.5 seconds
cmd/osmosisd/cmd/root.go Timeout for consensus changed from 2s to 1.5s
CHANGELOG.md Added query and whitelist; adjusted timeoutCommit

Possibly related issues

  • Default timeout to 2s #7907: This issue discusses setting the default timeoutCommit to 2 seconds, which conflicts with the reduction to 1.5 seconds in this PR. It may need updating or reevaluation in light of these changes.

🐇✨🌟
In the land of code, where the bits align,
A rabbit hopped, through lines so fine.
With a whisk of its tail, and a twitch of an ear,
From 2 to 1.5, the timeout did veer.
Celebrate the swift, with a cheer so bright! 🎉
🌟✨🐇


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 9b4fc5b and 2d0df84.
Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • cmd/osmosisd/cmd/init.go (1 hunks)
  • cmd/osmosisd/cmd/root.go (1 hunks)
Files skipped from review due to trivial changes (1)
  • cmd/osmosisd/cmd/root.go
Additional comments not posted (6)
cmd/osmosisd/cmd/init.go (1)

122-122: Change to TimeoutCommit setting looks good and aligns with the PR's objectives.

Please ensure to monitor the system's performance to verify that this change positively impacts the block processing times as intended.

CHANGELOG.md (5)

57-60: The entries under version v24.0.4 are correctly documented with appropriate links and descriptions.


57-60: The changes in version v24.0.3 are well-documented and include relevant GitHub issue links.


57-60: Entries for version v24.0.2 are clear and include necessary details for understanding the changes.


57-60: The API changes and new features in version v24.0.1 are accurately recorded with appropriate descriptions.


57-60: The major changes and new modules introduced in version v24.0.0 are thoroughly documented.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

CHANGELOG.md Show resolved Hide resolved
@czarcas7ic czarcas7ic merged commit 53e532b into main Apr 26, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the adam/1.5s-timeout branch April 26, 2024 20:43
mergify bot pushed a commit that referenced this pull request Apr 26, 2024
* 1.5s timeout commit default

* add changelog

(cherry picked from commit 53e532b)

# Conflicts:
#	CHANGELOG.md
czarcas7ic added a commit that referenced this pull request Apr 26, 2024
* chore: default timeout commit to 1.5s (#8149)

* 1.5s timeout commit default

* add changelog

(cherry picked from commit 53e532b)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Adam Tucker <adam@osmosis.team>
@PaddyMc PaddyMc mentioned this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v24.x backport patches to v24.x branch V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants